[jira] [Commented] (TINKERPOP-2646) Make .NET StreamExtensions public for GraphBinary

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441692#comment-17441692 ] 

ASF GitHub Bot commented on TINKERPOP-2646:
-------------------------------------------

FlorianHockmann opened a new pull request #1499:
URL: https://github.com/apache/tinkerpop/pull/1499


   https://issues.apache.org/jira/browse/TINKERPOP-2646
   
   They can now also be used by users and driver providers who implement their own custom GraphBinary types.
   I decided to change the signature of `ReadAsync()` a bit as it's easier to use if only the number of bytes to read has to be provided instead of a buffer that needs to have the correct length.
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make .NET StreamExtensions public for GraphBinary
> -------------------------------------------------
>
>                 Key: TINKERPOP-2646
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2646
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.5.1
>            Reporter: Florian Hockmann
>            Priority: Minor
>
> We added some extensions methods to the {{Stream}} class which are useful to implement GraphBinary serializers as that requires a lot of writing and reading of various types to streams:
> [https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/StreamExtensions.cs]
> We should make these extensions public to make them accessible for users and driver providers for their own custom GraphBinary types.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)