You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/10 16:34:46 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1928: add ResInfoTest.java ut
codecov-io edited a comment on issue #1928: add ResInfoTest.java ut
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1928#issuecomment-584208873
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928?src=pr&el=h1) Report
> Merging [#1928](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/c447bb489f5da45ca234a236551474778b24f2e3?src=pr&el=desc) will **increase** coverage by `0.7%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1928 +/- ##
=========================================
+ Coverage 25.01% 25.71% +0.7%
=========================================
Files 298 297 -1
Lines 14328 14551 +223
Branches 2350 2451 +101
=========================================
+ Hits 3584 3742 +158
- Misses 10299 10353 +54
- Partials 445 456 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apache/dolphinscheduler/common/utils/ResInfo.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Jlc0luZm8uamF2YQ==) | `92.59% <60%> (+92.59%)` | :arrow_up: |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `72.41% <0%> (-3.45%)` | :arrow_down: |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (ø)` | :arrow_up: |
| [...dolphinscheduler/dao/entity/ProcessDefinition.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzRGVmaW5pdGlvbi5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `40.87% <0%> (+5.2%)` | :arrow_up: |
| [.../apache/dolphinscheduler/common/utils/OSUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09TVXRpbHMuamF2YQ==) | `26.89% <0%> (+14.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928?src=pr&el=footer). Last update [c447bb4...1716234](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services