You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/03 22:45:35 UTC
[GitHub] [arrow] arw2019 opened a new pull request #8828: ARROW-10802: [C++] remove special casing for Dictionary[NullType] in parquet column writer
arw2019 opened a new pull request #8828:
URL: https://github.com/apache/arrow/pull/8828
ARROW-1648 was fixed a while back (in 0.8) so we can now rely on `arrow::compute::Cast`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on pull request #8828: ARROW-10802: [C++] remove special casing for Dictionary[NullType] in parquet column writer
Posted by GitBox <gi...@apache.org>.
arw2019 commented on pull request #8828:
URL: https://github.com/apache/arrow/pull/8828#issuecomment-739703303
> Do we already have a test for this case?
> Or should we add a new test for this case?
We test this already:
https://github.com/apache/arrow/blob/770851967898900c7014779a4463beacc5760745/cpp/src/parquet/arrow/arrow_reader_writer_test.cc#L1284-L1313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8828: ARROW-10802: [C++] remove special casing for Dictionary[NullType] in parquet column writer
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8828:
URL: https://github.com/apache/arrow/pull/8828#issuecomment-739698478
Do we already have a test for this case?
Or should we add a new test for this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8828: ARROW-10802: [C++] remove special casing for Dictionary[NullType] in parquet column writer
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8828:
URL: https://github.com/apache/arrow/pull/8828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8828: ARROW-10802: [C++] remove special casing for Dictionary[NullType] in parquet column writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8828:
URL: https://github.com/apache/arrow/pull/8828#issuecomment-738403556
https://issues.apache.org/jira/browse/ARROW-10802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org