You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chukwa.apache.org by "Bill Graham (JIRA)" <ji...@apache.org> on 2010/04/06 20:45:34 UTC
[jira] Created: (CHUKWA-473) Make default processor configurable
Make default processor configurable
-----------------------------------
Key: CHUKWA-473
URL: https://issues.apache.org/jira/browse/CHUKWA-473
Project: Hadoop Chukwa
Issue Type: New Feature
Reporter: Bill Graham
The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862357#action_12862357 ]
Ari Rabkin commented on CHUKWA-473:
-----------------------------------
[and thanks for putting up with random chaos from my end. ;)]
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch, CHUKWA-473.2.patch, CHUKWA-473.3.patch, CHUKWA-473.4.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854261#action_12854261 ]
Eric Yang commented on CHUKWA-473:
----------------------------------
+1 on Jerome's approach. It may be overly complex having a default package name.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated CHUKWA-473:
-------------------------------
Attachment: CHUKWA-473.1.patch
Attaching CHUKWA-473.1.patch, which implements default map and reduce processors. For the later the behavior is to look for a reducer class with name of reducerType, followed by the default setting, and finally the IdentityReducer.
Reduce processors are still bound by the constraint that they have to live in org.apache.hadoop.chukwa.extraction.demux.processor.reducer. If that's to be fixed, we should do so in a separate bug.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854637#action_12854637 ]
Eric Yang commented on CHUKWA-473:
----------------------------------
+1
{noformat}
chukwa.demux.mapper.default.processor
chukwa.demux.reducer.default.processor
{noformat}
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated CHUKWA-473:
-------------------------------
Status: Patch Available (was: Open)
Release Note: Default map and reduce processors are configurable.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854288#action_12854288 ]
Eric Yang commented on CHUKWA-473:
----------------------------------
My apology, I thought you were referring to the package name for "chukwa.demux.mapper.default.processor". Your naming convention is more concise for the config key name.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham reassigned CHUKWA-473:
----------------------------------
Assignee: Bill Graham
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854225#action_12854225 ]
Jerome Boulon commented on CHUKWA-473:
--------------------------------------
I'm not talking about changing the Mapper, I want the same thing as you want, aka running another processor on the mapper side and I want to be able to do the same thing on the reducer side.
So instead of:
String defaultProcessor = jobConf.get("chukwa.demux.default.map.processor",
"org.apache.hadoop.chukwa.extraction.demux.processor.mapper.DefaultProcessor");
I was thinking of something like this (it's just another name for the config key):
String defaultProcessor = jobConf.get("chukwa.demux.processor.defaultMapper",
"org.apache.hadoop.chukwa.extraction.demux.processor.mapper.DefaultProcessor");
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated CHUKWA-473:
-------------------------------
Attachment: CHUKWA-473.4.patch
Hmm. I'm not seeing any of these files committed. I saw commits for 479 and 480. Either way, here's an updated patch 4 built from the current trunk.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch, CHUKWA-473.2.patch, CHUKWA-473.3.patch, CHUKWA-473.4.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-473) Make default processor configurable
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin updated CHUKWA-473:
------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Just committed latest patch.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch, CHUKWA-473.2.patch, CHUKWA-473.3.patch, CHUKWA-473.4.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855458#action_12855458 ]
Bill Graham commented on CHUKWA-473:
------------------------------------
I've got a patch ready that makes the default map processor configurable, but just wanted to clarify how we want to do the same for the reducer processor. It looks for a class based on key.getReduceType() and falls back on IdentityReducer in ReduceProcessorFactory. Assuming that's what we want to be able to set a default for.
If so I need to change the signature of {{ReduceProcessorFactory.getProcessor(String reduceType)}} to either take a JobConf object or a default processor string, since I don't think that method should return null and delegate the default logic to the caller. I'm leaning slightly towards the later. Any opinions either way?
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854215#action_12854215 ]
Bill Graham commented on CHUKWA-473:
------------------------------------
This seems like a different use case to me. The existing Demux MapClass and ReduceClass work fine for me, but I just want to use a different processor in the mapper. I don't need to swap out the entire mapper/reducer class. In particular I want to swap out the following section in Demux.MapClass.map(..):
{noformat}
String processorClass = jobConf.get(chunk.getDataType(),
"org.apache.hadoop.chukwa.extraction.demux.processor.mapper.DefaultProcessor");
{noformat}
with something like this:
{noformat}
String defaultProcessor = jobConf.get("chukwa.demux.default.map.processor",
"org.apache.hadoop.chukwa.extraction.demux.processor.mapper.DefaultProcessor");
String processorClass = jobConf.get(chunk.getDataType(), defaultProcessor);
{noformat}
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854271#action_12854271 ]
Bill Graham commented on CHUKWA-473:
------------------------------------
Eric, I'm confused by your comment about a default package name and want to make sure we're all on the same page. Jerome and I are discussing the same approach and trying to decide on a config variable name. What are you referring to when you say "default package naming"? Just want to make sure we're all on the same page before I implement.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854354#action_12854354 ]
Bill Graham commented on CHUKWA-473:
------------------------------------
Jerome and I touched base offline and he suggested the following configs, which work for me. I'll go with these unless there's a better suggestion:
{noformat}
chukwa.demux.mapper.defaultMapProcessor
chukwa.demux.reducer.defaultReduceProcessor
{noformat}
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854122#action_12854122 ]
Jerome Boulon commented on CHUKWA-473:
--------------------------------------
Bill,
At Netflix I've changed a couple things and I have a separate config for mapper and reducer.
So could we do something like:
<property>
<name>chukwa.demux.processor.defaultMapper</name>
<value>org.apache.hadoop.chukwa.extraction.demux.processor.mapper.DefaultProcessor</value>
</property>
<property>
<name>chukwa.demux.processor.defaultReducer</name>
<value>org.apache.hadoop.chukwa.extraction.demux.processor.reducer.DefaultReducer</value>
</property>
Let me know if you need some guideline on how todo that.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854597#action_12854597 ]
Eric Yang commented on CHUKWA-473:
----------------------------------
Without camel case is more user friendly in my opinion, but Chukwa configurations are currently mixed of dot notation with camel case. Hence, my opinion doesn't matter.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857550#action_12857550 ]
Bill Graham commented on CHUKWA-473:
------------------------------------
There's plenty of room for refactoring the reducer code. I think we should limit the scope of this JIRA to making the default processors configurable though, and open another one for supporting aliases.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated CHUKWA-473:
-------------------------------
Attachment: CHUKWA-473.2.patch
Attaching a second patch with cleaned up unit tests.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch, CHUKWA-473.2.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857537#action_12857537 ]
Jerome Boulon commented on CHUKWA-473:
--------------------------------------
Since we are changing the reduce part, can we add aliases on the reducer side similar to what we have on the mapper side?
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860443#action_12860443 ]
Ari Rabkin commented on CHUKWA-473:
-----------------------------------
Unit tests fail for me. -1 to commit just yet.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch, CHUKWA-473.2.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854236#action_12854236 ]
Bill Graham commented on CHUKWA-473:
------------------------------------
OK cool, we're talking about the same functionality. Regarding the naming then, what was causing me confusion that your config name ends with 'defaultMapper'. It makes it look like the config takes a Mapper class. I think it would be more clear if we used language that refers to Processors or MapProcessors, not Mappers. This is because the thing that we're configuring is actually an instance of {{org.apache.hadoop.chukwa.extraction.demux.processor.mapper.MapProcessor}}, not {Mapper}.
What about {{chukwa.demux.mapper.default.processor}}?
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854636#action_12854636 ]
Bill Graham commented on CHUKWA-473:
------------------------------------
+1 for no camelcase actually. I think something like this reads better:
{noformat}
chukwa.demux.mapper.default.processor
chukwa.demux.reducer.default.processor
{noformat}
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHUKWA-473) Make default processor configurable
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated CHUKWA-473:
-------------------------------
Attachment: CHUKWA-473.3.patch
My bad, I missed a file in that last patch. Here's CHUKWA-473.3.patch.
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch, CHUKWA-473.2.patch, CHUKWA-473.3.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHUKWA-473) Make default processor configurable
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862272#action_12862272 ]
Ari Rabkin commented on CHUKWA-473:
-----------------------------------
I may have accidentally committed the previous version of this. :( Can you regenerate patch from current trunk if something isn't working?
Trunk unit tests pass, so I'm not quite sure what happened...
> Make default processor configurable
> -----------------------------------
>
> Key: CHUKWA-473
> URL: https://issues.apache.org/jira/browse/CHUKWA-473
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: CHUKWA-473.1.patch, CHUKWA-473.2.patch, CHUKWA-473.3.patch
>
>
> The default processor is hard coded to {{DefaultProcessor}} in the {{Demux}} class. This should be configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.