[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6030: Prevent the table creation when the time column name config is invalid

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#discussion_r490603362



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1226,6 +1231,27 @@ void validateTableTenantConfig(TableConfig tableConfig) {
     }
   }
 
+  void validateTimeColumnConfig(TableConfig tableConfig, Schema schema) {

Review comment:
       is this the right place? can we create a tableconfigvalidator @icefury71 you were also adding some validations right. lets move all validations related to tableconfig to one class




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org