You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/25 07:58:53 UTC
[GitHub] [spark] LuciferYang opened a new pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
LuciferYang opened a new pull request #31644:
URL: https://github.com/apache/spark/pull/31644
### What changes were proposed in this pull request?
Cleanup unused symbol in Orc related code as follows:
- `OrcDeserializer` : parameter `dataSchema` in constructor
- `OrcFilters` : parameter `schema ` in method `convertibleFilters`.
- `OrcPartitionReaderFactory`: `val resultSchemaString` in method `buildReader(file: PartitionedFile)`
### Why are the changes needed?
Cleanup code.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785860791
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135461/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31644:
URL: https://github.com/apache/spark/pull/31644
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785883841
Some test failed, let me check these
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785910926
**[Test build #135468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135468/testReport)** for PR 31644 at commit [`16b43ae`](https://github.com/apache/spark/commit/16b43ae89c3f4da7fbaf168fcc6712f12bf13d71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31644:
URL: https://github.com/apache/spark/pull/31644#discussion_r583297070
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcPartitionReaderFactory.scala
##########
@@ -98,8 +98,7 @@ case class OrcPartitionReaderFactory(
new EmptyPartitionReader[InternalRow]
} else {
val (requestedColIds, canPruneCols) = resultedColPruneInfo.get
- val resultSchemaString = OrcUtils.orcResultSchemaString(canPruneCols,
- dataSchema, resultSchema, partitionSchema, conf)
+ OrcUtils.orcResultSchemaString(canPruneCols, dataSchema, resultSchema, partitionSchema, conf)
Review comment:
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-786362976
thx ~ @HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785789065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40041/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785860791
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135461/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-786109723
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135468/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #31644:
URL: https://github.com/apache/spark/pull/31644#discussion_r582859339
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcPartitionReaderFactory.scala
##########
@@ -98,8 +98,7 @@ case class OrcPartitionReaderFactory(
new EmptyPartitionReader[InternalRow]
} else {
val (requestedColIds, canPruneCols) = resultedColPruneInfo.get
- val resultSchemaString = OrcUtils.orcResultSchemaString(canPruneCols,
- dataSchema, resultSchema, partitionSchema, conf)
+ OrcUtils.orcResultSchemaString(canPruneCols, dataSchema, resultSchema, partitionSchema, conf)
Review comment:
https://github.com/apache/spark/blob/4a3200b08ac3e7733b5a3dc7271d35e6872c5967/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala#L240-L253
@HyukjinKwon The previous failed test cases are mainly due to `OrcUtils.orcResultSchemaString` will set `resultSchemaString` to `conf`, so only ignore useless return value `val resultSchemaString` here .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785929975
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785951234
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785789065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40041/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-786097768
**[Test build #135468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135468/testReport)** for PR 31644 at commit [`16b43ae`](https://github.com/apache/spark/commit/16b43ae89c3f4da7fbaf168fcc6712f12bf13d71).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-786320438
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785728678
**[Test build #135461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135461/testReport)** for PR 31644 at commit [`bc25879`](https://github.com/apache/spark/commit/bc2587983520e87ec07fdbf854302c4a17b4bc3c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785985617
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785985617
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785860049
**[Test build #135461 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135461/testReport)** for PR 31644 at commit [`bc25879`](https://github.com/apache/spark/commit/bc2587983520e87ec07fdbf854302c4a17b4bc3c).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #31644:
URL: https://github.com/apache/spark/pull/31644#discussion_r582859339
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcPartitionReaderFactory.scala
##########
@@ -98,8 +98,7 @@ case class OrcPartitionReaderFactory(
new EmptyPartitionReader[InternalRow]
} else {
val (requestedColIds, canPruneCols) = resultedColPruneInfo.get
- val resultSchemaString = OrcUtils.orcResultSchemaString(canPruneCols,
- dataSchema, resultSchema, partitionSchema, conf)
+ OrcUtils.orcResultSchemaString(canPruneCols, dataSchema, resultSchema, partitionSchema, conf)
Review comment:
https://github.com/apache/spark/blob/4a3200b08ac3e7733b5a3dc7271d35e6872c5967/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala#L240-L253
@HyukjinKwon The previous failed test cases are mainly due to `OrcUtils.orcResultSchemaString` will set `resultSchemaString` to `conf`, change to only ignore useless return value `val resultSchemaString` here .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785910926
**[Test build #135468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135468/testReport)** for PR 31644 at commit [`16b43ae`](https://github.com/apache/spark/commit/16b43ae89c3f4da7fbaf168fcc6712f12bf13d71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-786323305
+1, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-785728678
**[Test build #135461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135461/testReport)** for PR 31644 at commit [`bc25879`](https://github.com/apache/spark/commit/bc2587983520e87ec07fdbf854302c4a17b4bc3c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31644:
URL: https://github.com/apache/spark/pull/31644#issuecomment-786109723
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135468/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org