You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/26 01:35:06 UTC
[GitHub] [superset] betodealmeida opened a new pull request #13353: feat: add Firebird DB engine spec
betodealmeida opened a new pull request #13353:
URL: https://github.com/apache/superset/pull/13353
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add a DB engine spec for [Firebird](https://firebirdsql.org/).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Connected Superset (running in `docker-compose`) to Firebird database running on my laptop. Added database, dataset, and queried.
Also tested all the time grains.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (5499509) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **increase** coverage by `3.29%`.
> The diff coverage is `57.69%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
+ Coverage 77.09% 80.38% +3.29%
==========================================
Files 876 301 -575
Lines 45439 24451 -20988
Branches 5440 0 -5440
==========================================
- Hits 35030 19656 -15374
+ Misses 10286 4795 -5491
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.26% <57.69%> (-0.05%)` | :arrow_down: |
| postgres | `80.30% <57.69%> (-0.05%)` | :arrow_down: |
| presto | `?` | |
| python | `80.38% <57.69%> (-0.47%)` | :arrow_down: |
| sqlite | `79.92% <57.69%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `54.16% <54.16%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.74% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [577 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...5499509](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (268f573) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `6.08%`.
> The diff coverage is `30.76%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.00% -6.09%
==========================================
Files 876 799 -77
Lines 45439 40763 -4676
Branches 5440 4167 -1273
==========================================
- Hits 35030 28945 -6085
- Misses 10286 11818 +1532
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.63% <28.87%> (-0.54%)` | :arrow_down: |
| hive | `79.93% <44.11%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `79.93% <44.11%> (-0.93%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [512 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...5499509](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583945268
##########
File path: superset/db_engine_specs/base.py
##########
@@ -456,7 +456,7 @@ def apply_limit_to_sql(cls, sql: str, limit: int, database: "Database") -> str:
)
return database.compile_sqla_query(qry)
- if LimitMethod.FORCE_LIMIT:
+ if cls.limit_method == LimitMethod.FORCE_LIMIT:
Review comment:
@robdiciuccio for reference: https://github.com/apache/superset/pull/13364
Added a unit test that would've caught the bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583889003
##########
File path: superset/db_engine_specs/base.py
##########
@@ -456,7 +456,7 @@ def apply_limit_to_sql(cls, sql: str, limit: int, database: "Database") -> str:
)
return database.compile_sqla_query(qry)
- if LimitMethod.FORCE_LIMIT:
+ if cls.limit_method == LimitMethod.FORCE_LIMIT:
Review comment:
@robdiciuccio I'll merge so we can hotfix this, and I'll add the tests in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (536a665) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.57%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.51% -5.58%
==========================================
Files 876 788 -88
Lines 45439 40629 -4810
Branches 5440 4137 -1303
==========================================
- Hits 35030 29056 -5974
- Misses 10286 11573 +1287
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `80.40% <57.69%> (-0.45%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [465 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...18c30e3](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (536a665) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **increase** coverage by `3.31%`.
> The diff coverage is `57.69%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
+ Coverage 77.09% 80.40% +3.31%
==========================================
Files 876 301 -575
Lines 45439 24445 -20994
Branches 5440 0 -5440
==========================================
- Hits 35030 19656 -15374
+ Misses 10286 4789 -5497
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `80.40% <57.69%> (-0.45%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `54.16% <54.16%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | | |
| [...d/src/dashboard/util/getLeafComponentIdFromPath.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExlYWZDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| ... and [562 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...18c30e3](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (9df47d2) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.60%`.
> The diff coverage is `34.31%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.48% -5.61%
==========================================
Files 876 799 -77
Lines 45439 40762 -4677
Branches 5440 4167 -1273
==========================================
- Hits 35030 29139 -5891
- Misses 10286 11623 +1337
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.62% <28.87%> (-0.55%)` | :arrow_down: |
| hive | `79.97% <75.00%> (-0.01%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.30% <75.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.34% <75.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.73% <75.00%> (-0.13%)` | :arrow_down: |
| sqlite | `79.96% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [493 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...3b562c0](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (3b562c0) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **increase** coverage by `3.34%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
+ Coverage 77.09% 80.43% +3.34%
==========================================
Files 876 301 -575
Lines 45439 24450 -20989
Branches 5440 0 -5440
==========================================
- Hits 35030 19666 -15364
+ Misses 10286 4784 -5502
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.30% <100.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.34% <100.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.43% <100.00%> (-0.43%)` | :arrow_down: |
| sqlite | `79.96% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <100.00%> (-0.49%)` | :arrow_down: |
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.74% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [577 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...3b562c0](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (536a665) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.33%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.76% -5.34%
==========================================
Files 876 788 -88
Lines 45439 40629 -4810
Branches 5440 4137 -1303
==========================================
- Hits 35030 29156 -5874
- Misses 10286 11473 +1187
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `79.97% <57.69%> (-0.04%)` | :arrow_down: |
| python | `80.81% <57.69%> (-0.04%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [461 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (18c30e3) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `6.22%`.
> The diff coverage is `57.69%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 70.87% -6.23%
==========================================
Files 876 784 -92
Lines 45439 40382 -5057
Branches 5440 4054 -1386
==========================================
- Hits 35030 28619 -6411
- Misses 10286 11763 +1477
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (-1.93%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `80.40% <57.69%> (-0.45%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `54.16% <54.16%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.09%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| ... and [464 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (fd97530) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.75%`.
> The diff coverage is `34.55%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.33% -5.76%
==========================================
Files 876 799 -77
Lines 45439 40762 -4677
Branches 5440 4167 -1273
==========================================
- Hits 35030 29077 -5953
- Misses 10286 11685 +1399
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.63% <28.87%> (-0.53%)` | :arrow_down: |
| hive | `79.97% <75.75%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `80.01% <75.75%> (-0.01%)` | :arrow_down: |
| python | `80.47% <75.75%> (-0.39%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [508 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...3b562c0](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio commented on a change in pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583872600
##########
File path: superset/db_engine_specs/base.py
##########
@@ -456,7 +456,7 @@ def apply_limit_to_sql(cls, sql: str, limit: int, database: "Database") -> str:
)
return database.compile_sqla_query(qry)
- if LimitMethod.FORCE_LIMIT:
+ if cls.limit_method == LimitMethod.FORCE_LIMIT:
Review comment:
This seems like a big change, but the default `limit_method` is `LimitMethod.FORCE_LIMIT` and the only overrides are `LimitMethod.WRAP_SQL` which returns before this block is executed, so this _should_ be ok.
Should we add some tests around this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583818668
##########
File path: superset/sql_lab.py
##########
@@ -205,7 +206,8 @@ def execute_sql_statement(
):
if SQL_MAX_ROW and (not query.limit or query.limit > SQL_MAX_ROW):
query.limit = SQL_MAX_ROW
- if query.limit:
+ # do not apply limit for databases that don't support LIMIT in the query
+ if query.limit and db_engine_spec.limit_method != LimitMethod.FETCH_MANY:
Review comment:
@dpgaspar we actually don't need this, in `apply_limit_to_sql` it already keeps the query unmodified if the method if `FETCH_MANY`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (9df47d2) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.78%`.
> The diff coverage is `34.31%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.30% -5.79%
==========================================
Files 876 799 -77
Lines 45439 40762 -4677
Branches 5440 4167 -1273
==========================================
- Hits 35030 29066 -5964
- Misses 10286 11696 +1410
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.62% <28.87%> (-0.55%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.30% <75.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.34% <75.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.43% <75.00%> (-0.43%)` | :arrow_down: |
| sqlite | `79.96% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...3b562c0](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (268f573) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.78%`.
> The diff coverage is `30.76%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.30% -5.79%
==========================================
Files 876 799 -77
Lines 45439 40763 -4676
Branches 5440 4167 -1273
==========================================
- Hits 35030 29066 -5964
- Misses 10286 11697 +1411
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.63% <28.87%> (-0.54%)` | :arrow_down: |
| hive | `79.93% <44.11%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `79.96% <44.11%> (-0.05%)` | :arrow_down: |
| python | `80.42% <44.11%> (-0.43%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [508 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...0c1e773](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (18c30e3) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.57%`.
> The diff coverage is `57.69%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.51% -5.58%
==========================================
Files 876 788 -88
Lines 45439 40629 -4810
Branches 5440 4137 -1303
==========================================
- Hits 35030 29055 -5975
- Misses 10286 11574 +1288
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.07% <ø> (-0.10%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `80.40% <57.69%> (-0.45%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `54.16% <54.16%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.09%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [456 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (536a665) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `6.90%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 70.18% -6.91%
==========================================
Files 876 784 -92
Lines 45439 40382 -5057
Branches 5440 4054 -1386
==========================================
- Hits 35030 28344 -6686
- Misses 10286 12038 +1752
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.51% <40.00%> (-3.66%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `80.40% <57.69%> (-0.45%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `77.41% <ø> (-22.59%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [475 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...18c30e3](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583790168
##########
File path: superset/db_engine_specs/firebird.py
##########
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from datetime import datetime
+from typing import Optional
+
+from superset.db_engine_specs.base import BaseEngineSpec, LimitMethod
+from superset.utils import core as utils
+
+
+class FirebirdEngineSpec(BaseEngineSpec):
+ """Engine for Google spreadsheets"""
Review comment:
Oops. I swear I didn't just copy and paste. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (532c0a3) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.37%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.72% -5.38%
==========================================
Files 876 788 -88
Lines 45439 40629 -4810
Branches 5440 4137 -1303
==========================================
- Hits 35030 29140 -5890
- Misses 10286 11489 +1203
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `79.95% <57.69%> (-0.03%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `?` | |
| presto | `79.97% <57.69%> (-0.04%)` | :arrow_down: |
| python | `80.75% <57.69%> (-0.11%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [466 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...5499509](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (fd97530) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `6.05%`.
> The diff coverage is `34.55%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.03% -6.06%
==========================================
Files 876 799 -77
Lines 45439 40762 -4677
Branches 5440 4167 -1273
==========================================
- Hits 35030 28956 -6074
- Misses 10286 11806 +1520
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.63% <28.87%> (-0.53%)` | :arrow_down: |
| hive | `79.97% <75.75%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `79.97% <75.75%> (-0.89%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [512 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...3b562c0](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio commented on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786366552
Tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583857678
##########
File path: superset/db_engine_specs/base.py
##########
@@ -456,7 +456,7 @@ def apply_limit_to_sql(cls, sql: str, limit: int, database: "Database") -> str:
)
return database.compile_sqla_query(qry)
- if LimitMethod.FORCE_LIMIT:
+ if cls.limit_method == LimitMethod.FORCE_LIMIT:
Review comment:
This fixes a bug that is almost 3 years old! :-P
https://github.com/apache/superset/pull/4947/files#diff-c1b45a05045ffe619c4c4fcd6b3d521a1875f21865a60c32a845f30ef86b95c3R106
The bug was never triggered because we didn't have any DB engine specs using `LimitMethod.FETCH_ALL`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (0c1e773) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `8.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 68.95% -8.14%
==========================================
Files 876 797 -79
Lines 45439 40713 -4726
Branches 5440 4143 -1297
==========================================
- Hits 35030 28073 -6957
- Misses 10286 12640 +2354
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.75% <ø> (-6.41%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.34% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.38% <100.00%> (-0.47%)` | :arrow_down: |
| sqlite | `79.96% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.09%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [486 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...acb407b](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583790357
##########
File path: superset/sql_lab.py
##########
@@ -205,7 +206,8 @@ def execute_sql_statement(
):
if SQL_MAX_ROW and (not query.limit or query.limit > SQL_MAX_ROW):
query.limit = SQL_MAX_ROW
- if query.limit:
+ # do not apply limit for databases that don't support LIMIT in the query
+ if query.limit and db_engine_spec.limit_method != LimitMethod.FETCH_MANY:
Review comment:
Sorry, what do you mean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (0c1e773) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.80%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.28% -5.81%
==========================================
Files 876 799 -77
Lines 45439 40763 -4676
Branches 5440 4167 -1273
==========================================
- Hits 35030 29057 -5973
- Misses 10286 11706 +1420
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.63% <ø> (-0.54%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.34% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.38% <100.00%> (-0.47%)` | :arrow_down: |
| sqlite | `79.96% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.09%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [476 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...acb407b](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (532c0a3) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.65%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.43% -5.66%
==========================================
Files 876 788 -88
Lines 45439 40601 -4838
Branches 5440 4137 -1303
==========================================
- Hits 35030 29003 -6027
- Misses 10286 11598 +1312
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.28% <57.69%> (-0.58%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [479 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583787590
##########
File path: superset/db_engine_specs/firebird.py
##########
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from datetime import datetime
+from typing import Optional
+
+from superset.db_engine_specs.base import BaseEngineSpec, LimitMethod
+from superset.utils import core as utils
+
+
+class FirebirdEngineSpec(BaseEngineSpec):
+ """Engine for Google spreadsheets"""
Review comment:
nit: Engine for Firebird
##########
File path: superset/sql_lab.py
##########
@@ -205,7 +206,8 @@ def execute_sql_statement(
):
if SQL_MAX_ROW and (not query.limit or query.limit > SQL_MAX_ROW):
query.limit = SQL_MAX_ROW
- if query.limit:
+ # do not apply limit for databases that don't support LIMIT in the query
+ if query.limit and db_engine_spec.limit_method != LimitMethod.FETCH_MANY:
Review comment:
Should we change this to base db_engine_spec instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (532c0a3) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.37%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.72% -5.38%
==========================================
Files 876 788 -88
Lines 45439 40629 -4810
Branches 5440 4137 -1303
==========================================
- Hits 35030 29140 -5890
- Misses 10286 11489 +1203
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `79.95% <57.69%> (-0.03%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `?` | |
| presto | `79.97% <57.69%> (-0.04%)` | :arrow_down: |
| python | `80.75% <57.69%> (-0.11%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [466 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (268f573) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `6.08%`.
> The diff coverage is `30.76%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.00% -6.09%
==========================================
Files 876 799 -77
Lines 45439 40761 -4678
Branches 5440 4167 -1273
==========================================
- Hits 35030 28943 -6087
- Misses 10286 11818 +1532
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.63% <28.87%> (-0.54%)` | :arrow_down: |
| hive | `79.92% <44.11%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `79.92% <44.11%> (-0.93%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [513 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...5499509](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (536a665) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.57%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.51% -5.58%
==========================================
Files 876 788 -88
Lines 45439 40629 -4810
Branches 5440 4137 -1303
==========================================
- Hits 35030 29056 -5974
- Misses 10286 11573 +1287
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `80.40% <57.69%> (-0.45%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [465 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (18c30e3) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **increase** coverage by `3.31%`.
> The diff coverage is `57.69%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
+ Coverage 77.09% 80.40% +3.31%
==========================================
Files 876 301 -575
Lines 45439 24445 -20994
Branches 5440 0 -5440
==========================================
- Hits 35030 19656 -15374
+ Misses 10286 4789 -5497
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `80.40% <57.69%> (-0.45%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `54.16% <54.16%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | | |
| ... and [575 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (fd97530) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `6.07%`.
> The diff coverage is `34.55%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.01% -6.08%
==========================================
Files 876 799 -77
Lines 45439 40734 -4705
Branches 5440 4167 -1273
==========================================
- Hits 35030 28929 -6101
- Misses 10286 11805 +1519
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.63% <28.87%> (-0.53%)` | :arrow_down: |
| hive | `79.95% <75.75%> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `79.95% <75.75%> (-0.90%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...3b562c0](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (536a665) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.39%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.69% -5.40%
==========================================
Files 876 788 -88
Lines 45439 40629 -4810
Branches 5440 4137 -1303
==========================================
- Hits 35030 29129 -5901
- Misses 10286 11500 +1214
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `80.32% <57.69%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `80.70% <57.69%> (-0.15%)` | :arrow_down: |
| sqlite | `79.94% <57.69%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [462 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (9df47d2) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.60%`.
> The diff coverage is `34.31%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.48% -5.61%
==========================================
Files 876 799 -77
Lines 45439 40762 -4677
Branches 5440 4167 -1273
==========================================
- Hits 35030 29140 -5890
- Misses 10286 11622 +1336
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.62% <28.87%> (-0.55%)` | :arrow_down: |
| hive | `79.97% <75.00%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.30% <75.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.34% <75.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.73% <75.00%> (-0.12%)` | :arrow_down: |
| sqlite | `79.96% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [492 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...3b562c0](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (9df47d2) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **increase** coverage by `3.34%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
+ Coverage 77.09% 80.43% +3.34%
==========================================
Files 876 301 -575
Lines 45439 24450 -20989
Branches 5440 0 -5440
==========================================
- Hits 35030 19666 -15364
+ Misses 10286 4784 -5502
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.30% <75.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.34% <75.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.43% <75.00%> (-0.43%)` | :arrow_down: |
| sqlite | `79.96% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.74% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | | |
| ... and [554 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...acb407b](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (532c0a3) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.46%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.62% -5.47%
==========================================
Files 876 788 -88
Lines 45439 40601 -4838
Branches 5440 4137 -1303
==========================================
- Hits 35030 29081 -5949
- Misses 10286 11520 +1234
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `79.93% <57.69%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.60% <57.69%> (-0.26%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [474 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
robdiciuccio edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786366552
Can you add some tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (268f573) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.78%`.
> The diff coverage is `30.76%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.30% -5.79%
==========================================
Files 876 799 -77
Lines 45439 40763 -4676
Branches 5440 4167 -1273
==========================================
- Hits 35030 29066 -5964
- Misses 10286 11697 +1411
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.63% <28.87%> (-0.54%)` | :arrow_down: |
| hive | `79.93% <44.11%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `79.96% <44.11%> (-0.05%)` | :arrow_down: |
| python | `80.42% <44.11%> (-0.43%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-6.37%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.29% <ø> (-7.71%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| ... and [508 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...5499509](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (532c0a3) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **decrease** coverage by `5.44%`.
> The diff coverage is `44.33%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
- Coverage 77.09% 71.64% -5.45%
==========================================
Files 876 788 -88
Lines 45439 40629 -4810
Branches 5440 4137 -1303
==========================================
- Hits 35030 29108 -5922
- Misses 10286 11521 +1235
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.08% <40.00%> (-0.09%)` | :arrow_down: |
| hive | `79.95% <57.69%> (-0.03%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.28% <57.69%> (-0.03%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.62% <57.69%> (-0.24%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.26% <0.00%> (+2.61%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `74.07% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `93.10% <ø> (-6.90%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <ø> (-64.29%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.54% <ø> (-6.46%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.47% <ø> (-4.13%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.82% <ø> (+1.21%)` | :arrow_up: |
| [...t-frontend/src/common/hooks/apiResources/charts.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvY2hhcnRzLnRz) | `16.66% <16.66%> (ø)` | |
| [...tend/src/common/hooks/apiResources/apiResources.ts](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy9hcGlSZXNvdXJjZXMvYXBpUmVzb3VyY2VzLnRz) | `17.64% <17.64%> (ø)` | |
| [superset-frontend/src/chart/ChartErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0RXJyb3JNZXNzYWdlLnRzeA==) | `20.00% <20.00%> (ø)` | |
| ... and [467 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...1b9b351](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #13353:
URL: https://github.com/apache/superset/pull/13353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13353: feat: add Firebird DB engine spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13353:
URL: https://github.com/apache/superset/pull/13353#issuecomment-786353691
# [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=h1) Report
> Merging [#13353](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=desc) (9df47d2) into [master](https://codecov.io/gh/apache/superset/commit/72721845e1e0c23956df51fd849539a61cb3e4ca?el=desc) (7272184) will **increase** coverage by `3.34%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13353 +/- ##
==========================================
+ Coverage 77.09% 80.43% +3.34%
==========================================
Files 876 301 -575
Lines 45439 24450 -20989
Branches 5440 0 -5440
==========================================
- Hits 35030 19666 -15364
+ Misses 10286 4784 -5502
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.30% <75.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.34% <75.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.43% <75.00%> (-0.43%)` | :arrow_down: |
| sqlite | `79.96% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.74% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/firebird.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ZpcmViaXJkLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [...dashboard/components/ColorSchemeControlWrapper.jsx](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yU2NoZW1lQ29udHJvbFdyYXBwZXIuanN4) | | |
| ... and [554 more](https://codecov.io/gh/apache/superset/pull/13353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=footer). Last update [7272184...3b562c0](https://codecov.io/gh/apache/superset/pull/13353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org