[GitHub] incubator-metron issue #530: METRON-777 Metron Extension System and Parser E...

[cestella <gi...@git.apache.org>]

Github user cestella commented on the issue:

    https://github.com/apache/incubator-metron/pull/530
  
    Woah, big contribution here; thanks @ottobackwards !  So this one is hard to review because a lot of it is:
    * Copied from NiFi's nar
    * Moving files around.
    
    Would you mind giving us a list of files where changes are made that don't fit those two categories?  I think that'd help us isolate the bits to review easier.
    
    In the meantime, I have a couple of questions:
    * Could you go over again why we needed the VM in travis?
    * What is the parser file size impact?  In other words, when we create a new bundle for a parser, are we shading and including all of metron-parser or is that isolated from the parser?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---