You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/15 09:45:11 UTC

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #5495: [IOTDB-2588] Triggers support any tree level, such as storage groups, devices, measurements, and so on

MarcosZyk commented on code in PR #5495:
URL: https://github.com/apache/iotdb/pull/5495#discussion_r851182652


##########
server/src/main/java/org/apache/iotdb/db/metadata/schemaregion/SchemaRegion.java:
##########
@@ -1158,6 +1158,11 @@ public List<MeasurementPath> getAllMeasurementByDevicePath(PartialPath devicePat
   // endregion
 
   // region Interfaces and methods for MNode query
+
+  public IMNode getNodeByPath(PartialPath path) throws MetadataException {
+    return mtree.getNodeByPath(path);
+  }

Review Comment:
   Remove this since we use specific interfaces for tirgger. It is not suggested to expose mnode, the internal structure of schemaRegion, to the outside module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org