[jira] [Commented] (SHIRO-337) adding support for CDI

["Brian Demers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHIRO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851662#comment-15851662 ] 

Brian Demers commented on SHIRO-337:
------------------------------------

Great! I'll take a closer look.

As for the dependency on the web module, things get a little sticky here.  And I think you are right on some of these points, we should fall back to non-web equivalent if a request is not available.  But... as far as dependencies go, requiring the servlet API as a dependency is a problem. If the code is written to allow that dependency to be optional, then it could work.



> adding support for CDI
> ----------------------
>
>                 Key: SHIRO-337
>                 URL: https://issues.apache.org/jira/browse/SHIRO-337
>             Project: Shiro
>          Issue Type: New Feature
>          Components: Integration: JEE
>    Affects Versions: 1.2.0, 1.2.1
>            Reporter: Romain Manni-Bucau
>            Priority: Critical
>              Labels: patch, patch-with-test
>         Attachments: SHIRO-337-2.patch, SHIRO-337-3.patch, SHIRO-337.patch
>
>
> As there is a spring or guice integration, a CDI integration could be welcomed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)