You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/24 02:25:09 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

HyukjinKwon opened a new pull request #29858:
URL: https://github.com/apache/spark/pull/29858


   ### What changes were proposed in this pull request?
   
   This PR removes Hive 1.2 option (and therefore `HIVE_VERSION` environment variable as well).
   
   ### Why are the changes needed?
   
   To remove unsupported options.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yeah, `HIVE_VERSION` and Hive 1.2 are removed.
   
   ### How was this patch tested?
   
   Manually tested:
   
   ```bash
   SPARK_VERSION=3.0.1 HADOOP_VERSION=3.2 pip install pyspark-3.1.0.dev0.tar.gz -v
   SPARK_VERSION=3.0.1 HADOOP_VERSION=2.7 pip install pyspark-3.1.0.dev0.tar.gz -v
   SPARK_VERSION=3.0.1 HADOOP_VERSION=invalid pip install pyspark-3.1.0.dev0.tar.gz -v
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698125610






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698074379






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698125610






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698077311


   Thank you~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698127658






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29858:
URL: https://github.com/apache/spark/pull/29858


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29858:
URL: https://github.com/apache/spark/pull/29858#discussion_r494042251



##########
File path: python/pyspark/install.py
##########
@@ -26,18 +26,13 @@
 DEFAULT_HADOOP = "hadoop3.2"
 DEFAULT_HIVE = "hive2.3"
 SUPPORTED_HADOOP_VERSIONS = ["hadoop2.7", "hadoop3.2", "without-hadoop"]
-SUPPORTED_HIVE_VERSIONS = ["hive1.2", "hive2.3"]
+SUPPORTED_HIVE_VERSIONS = ["hive2.3"]

Review comment:
       I checked offline with Xiao. Seems fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29858:
URL: https://github.com/apache/spark/pull/29858#discussion_r494006706



##########
File path: python/pyspark/install.py
##########
@@ -26,18 +26,13 @@
 DEFAULT_HADOOP = "hadoop3.2"
 DEFAULT_HIVE = "hive2.3"
 SUPPORTED_HADOOP_VERSIONS = ["hadoop2.7", "hadoop3.2", "without-hadoop"]
-SUPPORTED_HIVE_VERSIONS = ["hive1.2", "hive2.3"]
+SUPPORTED_HIVE_VERSIONS = ["hive2.3"]

Review comment:
       cc @gatorsmile 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698125610






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon removed a comment on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698075993


   @dongjoon-hyun, this affects end users, not the dev people who will use `hive-1.2` profile.
   I can file a separate JIRA but whenever the release distributions are changed, these should be updated together. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698124622


   **[Test build #129055 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129055/testReport)** for PR 29858 at commit [`41e83f3`](https://github.com/apache/spark/commit/41e83f3932d7680cb077bdd5c0b909b2c112fe76).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698125610






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698074003


   **[Test build #129055 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129055/testReport)** for PR 29858 at commit [`41e83f3`](https://github.com/apache/spark/commit/41e83f3932d7680cb077bdd5c0b909b2c112fe76).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698074003


   **[Test build #129055 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129055/testReport)** for PR 29858 at commit [`41e83f3`](https://github.com/apache/spark/commit/41e83f3932d7680cb077bdd5c0b909b2c112fe76).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698074003


   **[Test build #129055 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129055/testReport)** for PR 29858 at commit [`41e83f3`](https://github.com/apache/spark/commit/41e83f3932d7680cb077bdd5c0b909b2c112fe76).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29858:
URL: https://github.com/apache/spark/pull/29858#discussion_r494042251



##########
File path: python/pyspark/install.py
##########
@@ -26,18 +26,13 @@
 DEFAULT_HADOOP = "hadoop3.2"
 DEFAULT_HIVE = "hive2.3"
 SUPPORTED_HADOOP_VERSIONS = ["hadoop2.7", "hadoop3.2", "without-hadoop"]
-SUPPORTED_HIVE_VERSIONS = ["hive1.2", "hive2.3"]
+SUPPORTED_HIVE_VERSIONS = ["hive2.3"]

Review comment:
       I checked offline with Xiao. Seems fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698075993


   @dongjoon-hyun, this affects end users, not the dev people who will use `hive-1.2` profile.
   I can file a separate JIRA but whenever the release distributions are changed, these should be updated together. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698127658






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698074379






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698124622


   **[Test build #129055 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129055/testReport)** for PR 29858 at commit [`41e83f3`](https://github.com/apache/spark/commit/41e83f3932d7680cb077bdd5c0b909b2c112fe76).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29858:
URL: https://github.com/apache/spark/pull/29858


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29858: [SPARK-32982][BUILD] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29858:
URL: https://github.com/apache/spark/pull/29858#discussion_r494006706



##########
File path: python/pyspark/install.py
##########
@@ -26,18 +26,13 @@
 DEFAULT_HADOOP = "hadoop3.2"
 DEFAULT_HIVE = "hive2.3"
 SUPPORTED_HADOOP_VERSIONS = ["hadoop2.7", "hadoop3.2", "without-hadoop"]
-SUPPORTED_HIVE_VERSIONS = ["hive1.2", "hive2.3"]
+SUPPORTED_HIVE_VERSIONS = ["hive2.3"]

Review comment:
       cc @gatorsmile 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #29858: [SPARK-32981][BUILD][FOLLOW-UP] Remove hive-1.2 profiles in PIP installation option

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29858:
URL: https://github.com/apache/spark/pull/29858#issuecomment-698077240


   Sure, filing a separate JIRA is fine by me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org