You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by er...@apache.org on 2011/06/28 13:09:28 UTC

svn commit: r1140522 - /ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml

Author: erwan
Date: Tue Jun 28 11:09:28 2011
New Revision: 1140522

URL: http://svn.apache.org/viewvc?rev=1140522&view=rev
Log:
Wrong parameter was used when displaying the project's info: the workEffortId was used instead of parentProjectId

Modified:
    ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml

Modified: ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml?rev=1140522&r1=1140521&r2=1140522&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml (original)
+++ ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml Tue Jun 28 11:09:28 2011
@@ -233,8 +233,8 @@
         <field name="priority" title="${uiLabelMap.CommonPriority}"><display/></field>
         <field name="parentProjectId" title="${uiLabelMap.ProjectMgrParentProjectName}">
             <display-entity entity-name="WorkEffort" description="${workEffortName} ${workEffortId}" key-field-name="workEffortId">
-                <sub-hyperlink target="projectView" description="${workEffortId}" link-style="buttontext">
-                    <parameter param-name="projectId" from-field="workEffortId"/>
+                <sub-hyperlink target="projectView" description="${project.parentProjectId}" link-style="buttontext">
+                    <parameter param-name="projectId" from-field="project.parentProjectId"/>
                 </sub-hyperlink>
             </display-entity>
         </field>



Re: svn commit: r1140522 - /ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml

Posted by BJ Freeman <bj...@free-man.net>.
I an not sure the logic you are trying to make me aware of or how it
relates to what I am talking about.
when an entity-and is done foristance, you define the map that will be
stored in which would be say phase. That agree on. however
phase.fieldname should be the entity field name.
I can trace easliy were the map name is generated but when I have a
something like taskID instead of workeffortID I have to look further to
see how taskID was created since it is not part of the entity.


Hans Bakker sent the following on 7/9/2011 6:17 PM:
> BJ,
> 
> naming of project and also scrum entities is already required on the
> view level...there are views where the workeffort is already included
> three times, as project, phase and task.....
> 
> Regards,
> Hans
> 
> On Sat, 2011-07-09 at 13:39 -0700, BJ Freeman wrote:
>> sorry if I was not clear.
>> from a developers point of view and the original premise of ofbiz naming
>> was to have them reflect the entities they used.
>> once you got to the UI level then Naming the user saw, could be changed
>> to a more user friendly text.
>>
>>
>> Erwan de FERRIERES sent the following on 7/9/2011 1:13 PM:
>>> Le 03/07/2011 07:44, BJ Freeman a écrit :
>>>> I am confused. there is no fields about projects, only workeffort
>>>> parentProjectId =parentWorkeffortId with a workEffortTypeId ="PROJECT"
>>>
>>> Hi BJ,
>>>
>>> take a look to ProjectScreens.xml#ProjectView, you'll find all you need
>>> there.
>>>
>>> Cheers
>>>
> 

Re: svn commit: r1140522 - /ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml

Posted by Hans Bakker <ma...@antwebsystems.com>.
BJ,

naming of project and also scrum entities is already required on the
view level...there are views where the workeffort is already included
three times, as project, phase and task.....

Regards,
Hans

On Sat, 2011-07-09 at 13:39 -0700, BJ Freeman wrote:
> sorry if I was not clear.
> from a developers point of view and the original premise of ofbiz naming
> was to have them reflect the entities they used.
> once you got to the UI level then Naming the user saw, could be changed
> to a more user friendly text.
> 
> 
> Erwan de FERRIERES sent the following on 7/9/2011 1:13 PM:
> > Le 03/07/2011 07:44, BJ Freeman a écrit :
> >> I am confused. there is no fields about projects, only workeffort
> >> parentProjectId =parentWorkeffortId with a workEffortTypeId ="PROJECT"
> > 
> > Hi BJ,
> > 
> > take a look to ProjectScreens.xml#ProjectView, you'll find all you need
> > there.
> > 
> > Cheers
> > 

-- 
Ofbiz on twitter: http://twitter.com/apache_ofbiz
Myself on twitter: http://twitter.com/hansbak
Antwebsystems.com: Quality services for competitive rates.


Re: svn commit: r1140522 - /ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml

Posted by BJ Freeman <bj...@free-man.net>.
sorry if I was not clear.
from a developers point of view and the original premise of ofbiz naming
was to have them reflect the entities they used.
once you got to the UI level then Naming the user saw, could be changed
to a more user friendly text.


Erwan de FERRIERES sent the following on 7/9/2011 1:13 PM:
> Le 03/07/2011 07:44, BJ Freeman a écrit :
>> I am confused. there is no fields about projects, only workeffort
>> parentProjectId =parentWorkeffortId with a workEffortTypeId ="PROJECT"
> 
> Hi BJ,
> 
> take a look to ProjectScreens.xml#ProjectView, you'll find all you need
> there.
> 
> Cheers
> 

Re: svn commit: r1140522 - /ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml

Posted by Erwan de FERRIERES <er...@nereide.fr>.
Le 03/07/2011 07:44, BJ Freeman a écrit :
> I am confused. there is no fields about projects, only workeffort
> parentProjectId =parentWorkeffortId with a workEffortTypeId ="PROJECT"

Hi BJ,

take a look to ProjectScreens.xml#ProjectView, you'll find all you need 
there.

Cheers

-- 
Erwan de FERRIERES
www.nereide.biz

Re: svn commit: r1140522 - /ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml

Posted by BJ Freeman <bj...@free-man.net>.
I am confused. there is no fields about projects, only workeffort
parentProjectId =parentWorkeffortId with a workEffortTypeId ="PROJECT"

erwan@apache.org sent the following on 6/28/2011 4:09 AM:
> Author: erwan
> Date: Tue Jun 28 11:09:28 2011
> New Revision: 1140522
> 
> URL: http://svn.apache.org/viewvc?rev=1140522&view=rev
> Log:
> Wrong parameter was used when displaying the project's info: the workEffortId was used instead of parentProjectId
> 
> Modified:
>     ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
> 
> Modified: ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml?rev=1140522&r1=1140521&r2=1140522&view=diff
> ==============================================================================
> --- ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml (original)
> +++ ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ProjectForms.xml Tue Jun 28 11:09:28 2011
> @@ -233,8 +233,8 @@
>          <field name="priority" title="${uiLabelMap.CommonPriority}"><display/></field>
>          <field name="parentProjectId" title="${uiLabelMap.ProjectMgrParentProjectName}">
>              <display-entity entity-name="WorkEffort" description="${workEffortName} ${workEffortId}" key-field-name="workEffortId">
> -                <sub-hyperlink target="projectView" description="${workEffortId}" link-style="buttontext">
> -                    <parameter param-name="projectId" from-field="workEffortId"/>
> +                <sub-hyperlink target="projectView" description="${project.parentProjectId}" link-style="buttontext">
> +                    <parameter param-name="projectId" from-field="project.parentProjectId"/>
>                  </sub-hyperlink>
>              </display-entity>
>          </field>
> 
> 
>