[GitHub] [mynewt-core] kasjer commented on issue #2196: Full console: suppress new line when echo is disabled

[GitBox <gi...@apache.org>]

kasjer commented on issue #2196: Full console: suppress new line when echo is disabled
URL: https://github.com/apache/mynewt-core/pull/2196#issuecomment-596491990
 
 
   Hi @dwld quick question, are you using nlip protocol or some other custom protocol and you are not really interested in nlip handling?
   If you are not going to use nlip (that seem like reasonable option) that I will add switch to just disable nlip handling and this will reduce code size and runtime cpu usage.
   But what I've noticed when looking at you proposal is that console_echo() function that is public api for disabling console echo and it should not be used inside console code to turn on/off echo for other reason as it is done currently. And this also cries for fix.
   btw you proposal for call console_echo(echo); would not make any difference and could be just totally dropped to achieve same goal.
   Fixes are on the way...
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services