You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/04/09 15:47:20 UTC
[Issue 124638] New: Picture background crash
https://issues.apache.org/ooo/show_bug.cgi?id=124638
Issue ID: 124638
Issue Type: DEFECT
Summary: Picture background crash
Product: Writer
Version: 4.1.0-dev
Hardware: PC
OS: Linux64
Status: UNCONFIRMED
Keywords: crash, regression
Severity: major
Priority: P3
Component: formatting
Assignee: issues@openoffice.apache.org
Reporter: elish@apache.org
QA Contact: elish@apache.org
Flags: 4.1.0_release_blocker?
1. File - New - Text Document
2. Insert - Picture - From File... - Open
3. right click - Picture... - Background
Crash.
AOO410m14(Build:9760) - Rev. 1585624
2014-04-08_04:11:10 - Rev. 1585644
Debian
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
4.1.0_release_blocker canceled: [Issue 124638] Picture background
crash
Posted by bu...@apache.org.
Edwin Sharp <el...@apache.org> has canceled Edwin Sharp <el...@apache.org>'s
request for 4.1.0_release_blocker:
Issue 124638: Picture background crash
https://issues.apache.org/ooo/show_bug.cgi?id=124638
------- Additional Comments from Edwin Sharp <el...@apache.org>
Sorry!
No problem with
AOO410m15(Build:9761) - Rev. 1585426
2014-04-01 13:50 - Linux x86_64
Debian
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #3 from jsc@apache.org ---
I can't reproduce it on MacOS as well, with RC2
We don't accept showstopper from trunk!!! Can you confirm it on the RC2?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
Olli, you are right; I re-checked (afetr looking at the code) and can reproduce
in my cws, too. A first point to take action is SfxTabDialog::ActivatePageHdl
where there is a fallback to 1st page when page is not found, but that has an
error. Activating and asserting that.
Then it is indeed okay in a picture frame to have the Background TabPage, but
it seems not to be added/ inserted. Looking deeper...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
>From the code it's clear that the same should happen with OLEs, checked,
indeed. The mentioned fallback to 1st page works, I will add this to the fix.
The basic problem is that the SwFrmDlg is obviously used for the types
DLG_FRM_STD, DLG_FRM_GRF and DLG_FRM_OLE. Somehow I missed the GRF and OLE
cases, thus that dialog has no longer a Background TabPage.
The alternatives are:
(a) Add that TabPage again (only commented out for now) and use in the two
cases
(b) Extend OLE and GRF cases to also support the new fill attributes
While (a) is more simple, (b) is the way to the future; when we want to align
graphic objects bewteen Writer and DrawingLayer we will have to support the
DrawingLayer FillStyles anyways, thus I would prefer (b). The extra work will
be to apply the needed changes to the involved frames.
Olli, comments?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #15 from Armin Le Grand <Ar...@me.com> ---
Okay, going. I will commmit the fallback to 1st TabPage in TabPage dialog when
target TabPage is not found, plus asserting this, to get rid of the crash in
trunk...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #19 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Armin Le Grand from comment #18)
> Also thinking about page background - does it make sense to keep it on the
> old modes? I think not. Candidates also may be paragraph background and
> table fill/background
+1 for enhancing the other 'backgrounds', too
There is also row fill/background and cell fill/background
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #28 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1600568 into trunk:
i124638 Corrected relationship between DrawModel and DocShell in Writer,
made...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #17 from Armin Le Grand <Ar...@me.com> ---
Added support for DrawingLayer FillStyle for Writer Graphic and EmbeddedObject
frames, comitting. Done a lot of tests, too. The original EO and GRF frames
only supported a simple color fill, this is now unified and due to that widely
extended. Checkd back- and forth compatibility; the original AOOs can load more
complex fillings than they could define via UI.
During checks I stumbled over PageBackground which for now has to be handled as
an exception already (so far is the integration of the DrawingLayer
FillStyles). I am thinking about it - shouldn't we consequently also change
these to the DrawingLayer FillStyles for unification, too...?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #24 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1599233 into trunk:
i124638 Second step of DrawingLayer FillAttributes for Writer objects, now
ad...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #25 from Armin Le Grand <Ar...@me.com> ---
Saw that visualization with AA on/off and on the three main plattform differs,
need to correct that. Example: New Writer, type 'dt' + F3 (auto text expand),
give paragraph a gradient, type and add SIFT+Returns -> paint errors on mac and
linux, on non-AAed win, too. Investigating...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #21 from Armin Le Grand <Ar...@me.com> ---
Looking for Paragraph and PageBackgrounds...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #13 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Armin Le Grand from comment #10)
> From the code it's clear that the same should happen with OLEs, checked,
> indeed. The mentioned fallback to 1st page works, I will add this to the fix.
> The basic problem is that the SwFrmDlg is obviously used for the types
> DLG_FRM_STD, DLG_FRM_GRF and DLG_FRM_OLE. Somehow I missed the GRF and OLE
> cases, thus that dialog has no longer a Background TabPage.
> The alternatives are:
>
> (a) Add that TabPage again (only commented out for now) and use in the two
> cases
> (b) Extend OLE and GRF cases to also support the new fill attributes
>
> While (a) is more simple, (b) is the way to the future; when we want to
> align graphic objects bewteen Writer and DrawingLayer we will have to
> support the DrawingLayer FillStyles anyways, thus I would prefer (b). The
> extra work will be to apply the needed changes to the involved frames.
>
> Olli, comments?
My preference s also option (b)
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
Okay, that works. Lets see what else will be needed tomorrow.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
Sure, taking a look...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #16 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1588308 into trunk:
i124638 support for DrawingLayre FillStyle for GraphicFrames and
EmbeddedObje...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #11 from Armin Le Grand <Ar...@me.com> ---
DLG_FRM_OLE uses the same shell as DLG_FRM_STD, the SwFrameShell, so the
SwGrfShell::Execute uses the correct SfxItemSet using the ranges
XATTR_FILL_FIRST, XATTR_FILL_LAST for values and SID_COLOR_TABLE,
SID_BITMAP_LIST for the XLists.
DLG_FRM_GRF uses the SwGrfShell, there these are missing. These need to be
added (and I will need to sort the IDRanges...)
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--- Comment #2 from Oliver-Rainer Wittmann <or...@apache.org> ---
I reproduced the crash on Windows 7 with my local recent build from trunk (rev.
1585261).
I can not reproduce the crash with AOO 4.1.0 RC2 or AOO 4.1.0 Beta.
Thus, it seems that this issue is not relevant for our AOO 4.1.0 release
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #26 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1599676 into trunk:
i124638 Corrected paints of Writer Frames with DrawingLayer FillAttributes
fo...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #18 from Armin Le Grand <Ar...@me.com> ---
Also thinking about page background - does it make sense to keep it on the old
modes? I think not. Candidates also may be paragraph background and table
fill/background
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #14 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1587482 into trunk:
i124638 As a first step, avoid crash when a TabPage is not found for a
TabDia...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #23 from Armin Le Grand <Ar...@me.com> ---
Builds done, additional changes to sources to make it work applied. Checking
tiny repaint gaps on win...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #27 from Armin Le Grand <Ar...@me.com> ---
Saw that in Writer on trunk the ColorTable is not there when working with
SdrObjects. This has to do with the order of initialization of DrawModel and
DocShell. The DocShell gets SfxPoolItems set (*not* in a SfxItemSet (!)) and
the list ones for color and others need to be there for the ToolbarControls to
find these. The initializations for these are widely distributed over writer
and behave different depending in which order DrawModel and DocShell are
created (!). Trying to cleanup that stuff...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
This is strange; just checked my build of the branch alg_writerframes where I
developed this; it works flawless there. Preparing sw with debug...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #22 from Armin Le Grand <Ar...@me.com> ---
Preparing commit of Paragraph/PageBackground changes for Writer, building mac
and Linux versions...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
4.1.0_release_blocker requested: [Issue 124638] Picture background
crash
Posted by bu...@apache.org.
Edwin Sharp <el...@apache.org> has asked for 4.1.0_release_blocker:
Issue 124638: Picture background crash
https://issues.apache.org/ooo/show_bug.cgi?id=124638
------- Additional Comments from Edwin Sharp <el...@apache.org>
1. File - New - Text Document
2. Insert - Picture - From File... - Open
3. right click - Picture... - Background
Crash.
AOO410m14(Build:9760) - Rev. 1585624
2014-04-08_04:11:10 - Rev. 1585644
Debian
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
--- Comment #1 from jsc@apache.org ---
it helps if you report that you test a trunk nightly
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com,
| |orw@apache.org
Hardware|PC |All
Version|4.1.0-dev |4.2.0-dev
OS|Linux64 |All
--- Comment #5 from Oliver-Rainer Wittmann <or...@apache.org> ---
Armin: Could you have a look? I assume that the introduction of the new
background attributes caused this issue.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
Edwin Sharp <el...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|4.1.0_release_blocker? |
--- Comment #4 from Edwin Sharp <el...@apache.org> ---
Sorry!
No problem with
AOO410m15(Build:9761) - Rev. 1585426
2014-04-01 13:50 - Linux x86_64
Debian
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
Edwin Sharp <el...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #20 from Edwin Sharp <el...@apache.org> ---
No crash with
AOO410m18(Build:9764) - Rev. 1589052
2014-04-22 12:11 - Linux x86_64
Debian
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124638] Picture background crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124638
--- Comment #8 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Armin Le Grand from comment #7)
> This is strange; just checked my build of the branch alg_writerframes where
> I developed this; it works flawless there. Preparing sw with debug...
It was just a guess from my side that the integrated work from branch
alg_writerframes is related to this defect.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.