[GitHub] nifi pull request #3162: NIFI-5806 - remove SNMP target when stopping SNMP p...

[pvillard31 <gi...@git.apache.org>]

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/3162

    NIFI-5806 - remove SNMP target when stopping SNMP processors

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-5806

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3162
    
----
commit 3ce309c9a85f716751c61ea07b7b75d26688f325
Author: Pierre Villard <pi...@...>
Date:   2018-11-09T09:24:05Z

    NIFI-5806 - remove SNMP target when stopping SNMP processors

----


---

[GitHub] nifi pull request #3162: NIFI-5806 - remove SNMP target when stopping SNMP p...

[hemantha-kumara <gi...@git.apache.org>]

Github user hemantha-kumara commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3162#discussion_r232194884
  
    --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/AbstractSNMPProcessor.java ---
    @@ -252,6 +252,7 @@ public void close() {
                 this.getLogger().warn("Failure while closing UDP transport mapping", e);
             }
             this.snmp = null;
    +        this.snmpTarget = null;
    --- End diff --
    
    along with this change, I was wondering move below code block from ontrigger to onscheduled?
            
     synchronized (this) {
                 this.buildTargetResource(context);
             }


---