[GitHub] [superset] zhaoyongjie edited a comment on pull request #17168: fix: avoid filters containing null value

[GitBox <gi...@apache.org>]

zhaoyongjie edited a comment on pull request #17168:
URL: https://github.com/apache/superset/pull/17168#issuecomment-948280432


   > @zhaoyongjie does the filter box use this same endpoint? IIRC, the filter box select works with null values (the native filter one does, too, but it uses the chart data endpoint for this so won't be affected). If this doesn't affect the filter box then LGTM, otherwise we may need to add an additional param to the endpoint path to toggle between allowing/disallowing nulls and calling it without nulls only on the adhoc filter request.
   
   Good point! currently(after this PR), changed original behavior.
   
   For example, there is a table:
   ```
   SELECT 'foo' as foo 
   UNION 
   SELECT 'bar'
   UNION
   SELECT NULL
   -----------------------------
   foo
   NULL
   bar
   foo
   ```
   
   We call the filter endpoint `before`, the response was
   ```
   [None, 'bar', 'foo']
   ```
   
   and now, the response is
   ```
   ['bar', 'foo']
   ```
   
   but the None value is doesn't fit SQL where clause. for instance:
   ```
   SELECT col1
   FROM tbl
   WHERE col1 in (NULL)
   ```
   
   So, I think we can change old behavior safely. might be I have not considered it well, What do you think about it?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org