[GitHub] [jmeter] vlsi commented on pull request #5795: Dynamic charset for TcpSampler

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on PR #5795:
URL: https://github.com/apache/jmeter/pull/5795#issuecomment-1594426571

   Here's the build failure message:
   
   ```
   Execution failed for task ':src:protocol:tcp:autostyleJavaCheck'.
   > The following files have format violations:
       src/main/java/org/apache/jmeter/protocol/tcp/sampler/TCPClientImpl.java
         @@ -24,7 +24,6 @@
          import java.io.UnsupportedEncodingException;
          import java.nio.charset.Charset;
          
         -import org.apache.commons.lang3.StringUtils;
          import org.apache.jmeter.samplers.SampleResult;
          import org.apache.jmeter.util.JMeterUtils;
          import org.slf4j.Logger;
     You might want to adjust -PmaxCheckMessageLines=50
      -PmaxFilesToList=10
      -PminLinesPerFile=4
      to see more violations
     Run './gradlew autostyleApply' to fix the violations.
   ```
   
   It basically says you have an unused import which we would like to remove.
   
   If you execute `./gradlew autostyleApply`, it would apply the relevant changes.
   
   At the same time, it would be great if you could rebase your branch on top of a more recent master branch since CI and testing has been improved recently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org