You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by jgrzebyta <gi...@git.apache.org> on 2017/12/26 00:44:07 UTC

[GitHub] any23 pull request #51: Solved ANY23-316

GitHub user jgrzebyta opened a pull request:

    https://github.com/apache/any23/pull/51

    Solved ANY23-316

    Add handler for `null` values. Parser encodes all `null` values as RDF IRI `http://yaml.org/spec/1.2/spec.html#Null`.
    
    - create RDF value for null values: yaml:Null
    - update null-aware unit test
    - modify example for unit test: 'null' value is an item of a list

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jgrzebyta/any23 ANY23-316

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/any23/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit b786e899b738886e240e12a84c2c291c75ecd694
Author: Jacek Grzebyta <gr...@...>
Date:   2017-12-26T00:37:13Z

    Solved ANY23-316
    
    - create value for null values: yaml:Null
    - update null-aware unit test
    - modify example for unit test: 'null' value is an item of a list
    
    Signed-off-by: Jacek Grzebyta <gr...@gmail.com>

----


---

[GitHub] any23 pull request #51: Solved ANY23-316

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/any23/pull/51#discussion_r158862497
  
    --- Diff: core/src/test/java/org/apache/any23/extractor/yaml/YAMLExtractorTest.java ---
    @@ -125,7 +121,7 @@ public void treeTest() throws Exception {
                 RDFUtils.triple(RDFUtils.bnode(), RDFUtils.iri(ns, "value3"), RDFUtils.bnode("10")),
                 RDFUtils.triple(RDFUtils.bnode("10"), RDF.FIRST, RDFUtils.bnode("11")),
                 RDFUtils.triple(RDFUtils.bnode("11"), RDFUtils.iri(ns, "key3.1"), RDFUtils.bnode("12")),
    -            RDFUtils.triple(RDFUtils.bnode("12"), RDF.TYPE, RDF.LIST),
    +            // RDFUtils.triple(RDFUtils.bnode("12"), RDF.TYPE, RDF.LIST),
    --- End diff --
    
    @jgrzebyta I would just remove this code.


---

[GitHub] any23 pull request #51: Solved ANY23-316

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/any23/pull/51


---