[GitHub] [solr] TheSench commented on pull request #296: SOLR-15626: Fix `config-read` permission.

[GitBox <gi...@apache.org>]

TheSench commented on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-921732111


   > So... Thoughts on putting in a Unit Test? I think there is going to be a LOT of these types of issues, and that having tests would be great. I think you might be creating a new style of unit testing (well, really integration test), and would add a lot!
   > 
   > Some sort of way of having many security.json? `security-config-read.json` and `security-block-everyone.json` etc..?
   
   I agree that this would be very beneficial.  I'm still new to the codebase and my time for digging into this is currently quite limited.  It might take me a few weeks before I'm able to put some unit tests together for these.  Where are the integration tests currently located (or are there any existing integration tests)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org