[GitHub] [superset] ktmud commented on a change in pull request #13241: test: add Tests and Storybook for AsyncAceEditor

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #13241:
URL: https://github.com/apache/superset/pull/13241#discussion_r579776846



##########
File path: superset-frontend/spec/helpers/Worker.ts
##########
@@ -21,9 +21,12 @@ class Worker {
 
   onMessage: Function;
 
+  terminate: Function;
+
   constructor(stringUrl: string) {
     this.url = stringUrl;
     this.onMessage = () => {};
+    this.terminate = () => {};

Review comment:
       Could you explain why is this needed? Not sure how it this related to AsyncAceEditor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org