You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/22 03:49:46 UTC
[GitHub] [dolphinscheduler] zhuxt2015 commented on a diff in pull request #11088: [Fix-11007] [Master] fix forced_success bug
zhuxt2015 commented on code in PR #11088:
URL: https://github.com/apache/dolphinscheduler/pull/11088#discussion_r927264390
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskInstanceServiceImpl.java:
##########
@@ -193,7 +199,26 @@ public Map<String, Object> forceTaskSuccess(User loginUser, long projectCode, In
putMsg(result, Status.TASK_INSTANCE_STATE_OPERATION_ERROR, taskInstanceId, task.getState().toString());
return result;
}
-
+ // Workflow enforcement succeeded
+ ProcessInstance processInstance = processService.findProcessInstanceDetailById(task.getProcessInstanceId());
Review Comment:
Suggest extract a method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org