You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/18 14:46:39 UTC

[GitHub] JulieRossi opened a new pull request #3484: Create CsvResponse to manage csv exports encoding

JulieRossi opened a new pull request #3484: Create CsvResponse to manage csv exports encoding
URL: https://github.com/apache/incubator-superset/pull/3484
 
 
   Fix choosing encoding for writing csv with python3.
   
   Pandas does not manage encoding choices when writing csv on a file descriptor : https://github.com/pandas-dev/pandas/blob/master/pandas/io/common.py#L486
   This is a pandas issue (https://github.com/pandas-dev/pandas/issues/13068).
   
   To fix this, I propose to change the encoding as Response level.
   
   fix https://github.com/apache/incubator-superset/issues/1519#issuecomment-330187976
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services