You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/02/09 15:31:58 UTC
[GitHub] [airflow] jedcunningham commented on a diff in pull request #29309: Add `airflow db drop-archived` command
jedcunningham commented on code in PR #29309:
URL: https://github.com/apache/airflow/pull/29309#discussion_r1101637903
##########
docs/apache-airflow/howto/usage-cli.rst:
##########
@@ -232,6 +232,18 @@ location must exist.
Other options include: ``--tables`` to specify the tables to export, ``--drop-archives`` to drop the archive tables after
exporting.
+Dropping the archived tables
+----------------------------
+If during the ``db clean`` process, you did not use the ``--skip-archive`` option which drops the archived table, you can
+still drop the archive tables using the ``db drop-archived`` command. This operation is irreversible and you are encouraged
+to use ``db export-cleaned`` command to backup the tables to disk before dropping them.
+
+You can specify the tables to drop using the ``--tables`` option. If no tables are specified, all archive tables will be
+dropped.
+
+For help on the ``db drop-archived`` command, run: ``airflow db drop-archived --help``.
+
+
Review Comment:
```suggestion
```
I don't think we should add this, `--help` is a thing for every command.
##########
docs/apache-airflow/howto/usage-cli.rst:
##########
@@ -232,6 +232,18 @@ location must exist.
Other options include: ``--tables`` to specify the tables to export, ``--drop-archives`` to drop the archive tables after
exporting.
+Dropping the archived tables
+----------------------------
Review Comment:
```suggestion
----------------------------
```
##########
docs/apache-airflow/howto/usage-cli.rst:
##########
@@ -232,6 +232,18 @@ location must exist.
Other options include: ``--tables`` to specify the tables to export, ``--drop-archives`` to drop the archive tables after
exporting.
+Dropping the archived tables
+----------------------------
+If during the ``db clean`` process, you did not use the ``--skip-archive`` option which drops the archived table, you can
+still drop the archive tables using the ``db drop-archived`` command. This operation is irreversible and you are encouraged
+to use ``db export-cleaned`` command to backup the tables to disk before dropping them.
Review Comment:
```suggestion
to use the ``db export-cleaned`` command to backup the tables to disk before dropping them.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org