You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jordan Zimmerman (Created) (JIRA)" <ji...@apache.org> on 2011/10/27 23:46:32 UTC
[jira] [Created] (ZOOKEEPER-1262) Documentation for Lock recipe has
major flaw
Documentation for Lock recipe has major flaw
--------------------------------------------
Key: ZOOKEEPER-1262
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
Project: ZooKeeper
Issue Type: Bug
Components: documentation
Affects Versions: 3.3.3
Reporter: Jordan Zimmerman
The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143555#comment-13143555 ]
Hadoop QA commented on ZOOKEEPER-1262:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502217/patch.txt
against trunk revision 1196819.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/773//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/773//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/773//console
This message is automatically generated.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139368#comment-13139368 ]
Patrick Hunt commented on ZOOKEEPER-1262:
-----------------------------------------
my response on list:
You're right, we should have an "error handling" section in that doc,
the assumption is that this is the algo when things are working, but
what happens if things go awry?
One way to handle the issue you describe, is when the client
reconnects to the cluster, if the session is not expired it could look
at any outstanding requests it made and not gotten responses for. In
this case it could scan the list looking for any znode that it created
(see the Stat object) and make a determination based on that.
I see you entered ZOOKEEPER-1262, perhaps you could supply a patch to
the docs detailing this?
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1262) Documentation for Lock recipe has
major flaw
Posted by "Jordan Zimmerman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman updated ZOOKEEPER-1262:
----------------------------------------
Attachment: patch.txt
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1262) Documentation for Lock recipe has
major flaw
Posted by "Mahadev konar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1262:
-------------------------------------
Fix Version/s: 3.4.1
Looks like a harmless change that could get into 3.4.1.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.5.0, 3.4.1
>
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Patrick Hunt (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1262:
---------------------------------------
Assignee: Jordan Zimmerman
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.5.0
>
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140494#comment-13140494 ]
Patrick Hunt commented on ZOOKEEPER-1262:
-----------------------------------------
Hi Jordan - you do have access, the doc source is in src/docs/src/documentation/content/xdocs/ if you checkout ZK trunk (or any branch for that matter) from SVN.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1262) Documentation for Lock recipe has
major flaw
Posted by "Mahadev konar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1262:
-------------------------------------
Fix Version/s: (was: 3.4.1)
I just committed this to trunk. The patch doesnt apply for 3.4 branch so am skipping this for 3.4 branch
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.5.0
>
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Patrick Hunt (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reopened ZOOKEEPER-1262:
-------------------------------------
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166070#comment-13166070 ]
Hudson commented on ZOOKEEPER-1262:
-----------------------------------
Integrated in ZooKeeper-trunk #1389 (See [https://builds.apache.org/job/ZooKeeper-trunk/1389/])
ZOOKEEPER-1262. Documentation for Lock recipe has major flaw. (Jordan Zimmerman via mahadev)
mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212166
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/docs/bookkeeperConfig.pdf
* /zookeeper/trunk/docs/bookkeeperOverview.pdf
* /zookeeper/trunk/docs/bookkeeperProgrammer.pdf
* /zookeeper/trunk/docs/bookkeeperStarted.pdf
* /zookeeper/trunk/docs/bookkeeperStream.pdf
* /zookeeper/trunk/docs/index.pdf
* /zookeeper/trunk/docs/javaExample.pdf
* /zookeeper/trunk/docs/linkmap.pdf
* /zookeeper/trunk/docs/recipes.html
* /zookeeper/trunk/docs/recipes.pdf
* /zookeeper/trunk/docs/releasenotes.pdf
* /zookeeper/trunk/docs/zookeeperAdmin.html
* /zookeeper/trunk/docs/zookeeperAdmin.pdf
* /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.pdf
* /zookeeper/trunk/docs/zookeeperInternals.pdf
* /zookeeper/trunk/docs/zookeeperJMX.pdf
* /zookeeper/trunk/docs/zookeeperObservers.pdf
* /zookeeper/trunk/docs/zookeeperOver.pdf
* /zookeeper/trunk/docs/zookeeperProgrammers.pdf
* /zookeeper/trunk/docs/zookeeperQuotas.pdf
* /zookeeper/trunk/docs/zookeeperStarted.pdf
* /zookeeper/trunk/docs/zookeeperTutorial.pdf
* /zookeeper/trunk/src/docs/src/documentation/content/xdocs/recipes.xml
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.5.0
>
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165534#comment-13165534 ]
Hadoop QA commented on ZOOKEEPER-1262:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502217/patch.txt
against trunk revision 1208979.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/816//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/816//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/816//console
This message is automatically generated.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.5.0, 3.4.1
>
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Jordan Zimmerman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140459#comment-13140459 ]
Jordan Zimmerman commented on ZOOKEEPER-1262:
---------------------------------------------
FYI - I don't have access to the website source so this is just a diff.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Jordan Zimmerman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143514#comment-13143514 ]
Jordan Zimmerman commented on ZOOKEEPER-1262:
---------------------------------------------
Real patch added.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Patrick Hunt (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt resolved ZOOKEEPER-1262.
-------------------------------------
Resolution: Fixed
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140452#comment-13140452 ]
Hadoop QA commented on ZOOKEEPER-1262:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501645/recipes.diff
against trunk revision 1190450.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/751//console
This message is automatically generated.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Jordan Zimmerman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139421#comment-13139421 ]
Jordan Zimmerman commented on ZOOKEEPER-1262:
---------------------------------------------
Sure - I'll work on something.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Jordan Zimmerman (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman reopened ZOOKEEPER-1262:
-----------------------------------------
Hmm - maybe I shouldn't have closed this.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: patch.txt, recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1262) Documentation for Lock recipe has
major flaw
Posted by "Jordan Zimmerman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman updated ZOOKEEPER-1262:
----------------------------------------
Attachment: recipes.html
recipes.diff
Here is an updated recipes page (and its diff)
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Jordan Zimmerman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140497#comment-13140497 ]
Jordan Zimmerman commented on ZOOKEEPER-1262:
---------------------------------------------
Ah - OK - I'll go to it and make a patch
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
> Attachments: recipes.diff, recipes.html
>
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1262) Documentation for Lock recipe
has major flaw
Posted by "Jordan Zimmerman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137701#comment-13137701 ]
Jordan Zimmerman commented on ZOOKEEPER-1262:
---------------------------------------------
Actually, using the SessionID is not very good. You would only be able to create 1 lock per path per connection. Using a UUID would be better.
> Documentation for Lock recipe has major flaw
> --------------------------------------------
>
> Key: ZOOKEEPER-1262
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.3.3
> Reporter: Jordan Zimmerman
>
> The recipe for Locks documented here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_recipes_Locks doesn't deal with the problem of create() succeeding but the server crashing before the result is returned. As written, if the server crashes before the result is returned the client can never know what sequential node was created for it. The way to deal with this is to embed the session ID in the node name. The Lock implementation in the ZK distro does this. But, the documentation will lead implementors to write bad code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira