You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/26 21:51:07 UTC

[GitHub] [airflow] tooptoop4 opened a new pull request #6907: AIRFLOW-6349

tooptoop4 opened a new pull request #6907: AIRFLOW-6349
URL: https://github.com/apache/airflow/pull/6907
 
 
   AIRFLOW-6349
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6907: [AIRFLOW-6349] - secure api and cookie by default

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6907: [AIRFLOW-6349] - secure api and cookie by default
URL: https://github.com/apache/airflow/pull/6907#discussion_r362187074
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -240,7 +240,7 @@ fail_fast = False
 
 [api]
 # How to authenticate users of the API
-auth_backend = airflow.api.auth.backend.default
+auth_backend = airflow.api.auth.backend.deny_all
 
 Review comment:
   Can you add note in UPDATING.MD? Some may install AIRFLOW automatically and may be surprised that the default value has changed.  I also think that he should change the name of package `airflow.api.auth.backend.deny_all  to a different one to better describe the content.
   I also noticed that another person(me) is already working on it.
   https://github.com/apache/airflow/pull/6625/files
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] tooptoop4 commented on issue #6907: [AIRFLOW-6349] - secure api and cookie by default

Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6907: [AIRFLOW-6349] - secure api and cookie by default
URL: https://github.com/apache/airflow/pull/6907#issuecomment-570305121
 
 
   closing as dupe of https://github.com/apache/airflow/pull/6625/files

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] tooptoop4 closed pull request #6907: [AIRFLOW-6349] - secure api and cookie by default

Posted by GitBox <gi...@apache.org>.
tooptoop4 closed pull request #6907: [AIRFLOW-6349] - secure api and cookie by default
URL: https://github.com/apache/airflow/pull/6907
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services