[GitHub] [kafka] dejan2609 commented on a change in pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

[GitBox <gi...@apache.org>]

dejan2609 commented on a change in pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#discussion_r632057098



##########
File path: build.gradle
##########
@@ -849,7 +849,7 @@ project(':core') {
     compile.exclude module: 'mail'
     // To prevent a UniqueResourceException due the same resource existing in both
     // org.apache.directory.api/api-all and org.apache.directory.api/api-ldap-schema-data
-    testCompile.exclude module: 'api-ldap-schema-data'
+    all*.exclude module: 'api-ldap-schema-data'

Review comment:
       > Does it also cause problems for the `compile` lines above the one you changed?
   
   No, not at all. It only modifies exclusion level for a single dependency (referenced here as a module 'api-ldap-schema-data'). Isolated change, atomic level.
   
   As for a your first question:
   > Is it related to the fact that we changed a bunch of things from `compile` to `implementation`/`api` and from `testCompile` to `testImplementation`?
   
    you just helped me to realize that this was the **last** `testCompile` reference in a project !
   
   Some details: 
   * Gradle 6.8.3: `testCompile` is deprecated and superseded by `testImplementation`: https://docs.gradle.org/6.8.3/userguide/java_plugin.html#sec:java_plugin_and_dependency_management
   * Gradle 7.0.1: `testCompile` is removed (doesn't exists): https://docs.gradle.org/7.0.1/userguide/java_plugin.html#sec:java_plugin_and_dependency_management
   
   So, puzzle is solved, I guess: I assume that Gradle 7 is just skipping  directive `testCompile.exclude module: 'api-ldap-schema-data`  and hence 'UniqueResourceException' are rising again from the dust... 
   Now, **this** could be a regression/bug in Gradle 7, I guess I will inform Gradle team.
   
   And of course, now I do realize that we could try to switch from `testCompile` to `testImplementation' for this exclusion also (it is looks appropriate). I will test this on my end.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org