You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by wind0727 <gi...@git.apache.org> on 2016/05/11 09:05:21 UTC

[GitHub] incubator-zeppelin pull request: Note Permission: if input userNam...

GitHub user wind0727 opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/884

    Note Permission: if input userName is not exists of shiro.ini,cannot save!

    ### What is this PR for?
    Note Permission: if input userName is not exists of shiro.ini,cannot save!
    
    
    ### What type of PR is it?
    Bug
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    no
    
    ### How should this be tested?
    1. click one notebook,into notebook edit page.
    2. click Note Permission button.
    3. Owners/Readers/Writers: input any word of shrio.ini not exists
    4. Pop-up prompt: User: "" is not exists, Please Check!
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wind0727/incubator-zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #884
    
----
commit af308901c14563697329f0af110e31f412b48fee
Author: wind0727 <82...@qq.com>
Date:   2016-05-06T07:31:21Z

    Update SecurityUtils.java

commit 76fb0d0cf5d0108c6c9a47d27499dd9d90b67560
Author: wind0727 <82...@qq.com>
Date:   2016-05-06T09:54:20Z

    Update SecurityUtils.java

commit 9f3b850808daf51fea3c52e2f7b4f6833dbd432a
Author: wind0727 <82...@qq.com>
Date:   2016-05-11T08:49:07Z

    Update SecurityUtils.java

commit d91c933c3da6cf598e06d25048fb62b07e081b6b
Author: wind0727 <82...@qq.com>
Date:   2016-05-11T08:56:35Z

    Update NotebookRestApi.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Note Permission: If userName does...

Posted by wind0727 <gi...@git.apache.org>.

Github user wind0727 commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/884#issuecomment-219594273
  
    OK,I try to change it,
    
    Failed tests: 
      NotebookRestApiTest.testPermissions:70 test update method:
    Expected: HTTP response <200> from /api/notebook/2BJ8WCYBQ/permissions/
         but: got <403> Forbidden
    
    what\u2018s problem is this?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Note Permission: If userName does...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/884#issuecomment-219578270
  
    Thanks @wind0727 for the bug fix.
    
    Are modifications of line 141~163 and 713~729 of NotebookRestApi.java part of this contribution?
    If not, could you try include changes for this contribution only? Let me know if you need any help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin issue #884: Note Permission: If userName does not exist i...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/incubator-zeppelin/pull/884
  
    @wind0727 The history is a bit weird.
    Could you create a new branch (not based on master) and create a new PR?
    This will clean the history and take care of conflicts


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---