You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/12/03 01:10:48 UTC
[GitHub] [hadoop] xinglin commented on a diff in pull request #5160: HDFS-16852 Swallow IllegalStateException in KeyProviderCache constructor
xinglin commented on code in PR #5160:
URL: https://github.com/apache/hadoop/pull/5160#discussion_r1038655791
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/KeyProviderCache.java:
##########
@@ -68,8 +68,11 @@ public void onRemoval(
})
.build();
- ShutdownHookManager.get().addShutdownHook(new KeyProviderCacheFinalizer(),
- SHUTDOWN_HOOK_PRIORITY);
+ try {
+ ShutdownHookManager.get().addShutdownHook(new KeyProviderCacheFinalizer(), SHUTDOWN_HOOK_PRIORITY);
+ } catch (IllegalStateException e) {
+ LOG.warn("shutdownHook not added", e);
+ }
Review Comment:
Thanks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org