You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by ayudovin <gi...@git.apache.org> on 2018/08/05 09:27:08 UTC
[GitHub] cassandra pull request #245: rejected execution exception logged when task a...
GitHub user ayudovin opened a pull request:
https://github.com/apache/cassandra/pull/245
rejected execution exception logged when task already completed
this [improvement](https://issues.apache.org/jira/browse/CASSANDRA-12926)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ayudovin/cassandra 12926-reject-exception-when-task-completed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra/pull/245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #245
----
commit ad43f99521024cda1898dc92ca2fa601cf8420b1
Author: artsiom <a....@...>
Date: 2018-08-05T09:23:33Z
rejected execution exception logged when task already completed
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra issue #245: [CASSANDRA-12926] - rejected execution exception logge...
Posted by ayudovin <gi...@git.apache.org>.
Github user ayudovin commented on the issue:
https://github.com/apache/cassandra/pull/245
@michaelsembwever ok, no problem, thank you
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra issue #245: [CASSANDRA-12926] - rejected execution exception logge...
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on the issue:
https://github.com/apache/cassandra/pull/245
(test for INFRA-16879 .please ignore)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra pull request #245: [CASSANDRA-12926] - rejected execution exceptio...
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/245#discussion_r208486203
--- Diff: src/java/org/apache/cassandra/repair/SnapshotTask.java ---
@@ -77,7 +77,10 @@ public void response(MessageIn msg)
public void onFailure(InetAddressAndPort from, RequestFailureReason failureReason)
{
//listener.failedSnapshot();
- task.setException(new RuntimeException("Could not create snapshot at " + from));
+ if (!task.isDone())
+ {
+ task.setException(new RuntimeException("Could not create snapshot at " + from));
+ }
--- End diff --
(test for INFRA-16879 .please ignore)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra issue #245: [CASSANDRA-12926] - rejected execution exception logge...
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on the issue:
https://github.com/apache/cassandra/pull/245
@ayudovin apologies, these comments are just to test a change in the infrastructure to the cassandra project: https://issues.apache.org/jira/browse/INFRA-16879
once i sort that out i will delete these comments, and then i can help you with the actual PR. again apologises for hijacking your PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra issue #245: [CASSANDRA-12926] - rejected execution exception logge...
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on the issue:
https://github.com/apache/cassandra/pull/245
(test for INFRA-16879 .please ignore)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra issue #245: [CASSANDRA-12926] - rejected execution exception logge...
Posted by ayudovin <gi...@git.apache.org>.
Github user ayudovin commented on the issue:
https://github.com/apache/cassandra/pull/245
@michaelsembwever, It's my first pull request to Cassandra and it'll be great if you help me because i'm sure that i understand what you mean in this comment "(test for INFRA-16879 .please ignore)"
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra pull request #245: [CASSANDRA-12926] - rejected execution exceptio...
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/245#discussion_r208737383
--- Diff: src/java/org/apache/cassandra/repair/SnapshotTask.java ---
@@ -77,7 +77,10 @@ public void response(MessageIn msg)
public void onFailure(InetAddressAndPort from, RequestFailureReason failureReason)
{
//listener.failedSnapshot();
- task.setException(new RuntimeException("Could not create snapshot at " + from));
+ if (!task.isDone())
+ {
+ task.setException(new RuntimeException("Could not create snapshot at " + from));
+ }
--- End diff --
(test for INFRA-16879 .please ignore)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra issue #245: [CASSANDRA-12926] - rejected execution exception logge...
Posted by Humbedooh <gi...@git.apache.org>.
Github user Humbedooh commented on the issue:
https://github.com/apache/cassandra/pull/245
(re-test for infra)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org