You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/22 02:25:48 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

Apache9 commented on a change in pull request #2889:
URL: https://github.com/apache/hbase/pull/2889#discussion_r562337042



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -921,8 +921,10 @@ public boolean isClusterShutdown() {
   public void startChore() {
     Configuration c = master.getConfiguration();
     if (persistFlushedSequenceId) {
-      // when reach here, RegionStates should loaded, firstly, we call remove deleted regions
-      removeDeletedRegionFromLoadedFlushedSequenceIds();
+      new Thread(() -> {

Review comment:
       We will both touch flushedSequenceIdByRegion and storeFlushedSequenceIdsByRegion in persistRegionLastFlushedSequenceIds and removeDeletedRegionFromLoadedFlushedSequenceIds? Possible data race if we run removeDeletedRegionFromLoadedFlushedSequenceIds in background?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org