You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 12:06:25 UTC
Review Request 70103: Removed outdated scaling framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70103/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos
Description
-------
This old code was never updated for recent changes, is not documented,
and currently does not work anymore. Removing it for now. Should we
decide to bring it back in the future we should make sure it is tested
automatically so it does not go out of sync again, and also that it is
documented and discoverable by users.
Diffs
-----
src/scaling/nested_exec 45ba1260e476ee20dfe013a0406f650639e9a800
src/scaling/nested_exec.py 28ccc3f5af2d293be8d810f7082dd43388ab4435
src/scaling/scaling_exec 3be8bc8b5bf7a1f4386db2dda82b8663d522d065
src/scaling/scaling_exec.py e9f4a86b29485559323241587879fab946e69841
src/scaling/scaling_sched 5c6c2476ed6a0b1275011c394f6834eef7b3a134
src/scaling/scaling_sched.py 011e353b12465076d96378cccbc5a0ff88231844
Diff: https://reviews.apache.org/r/70103/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 70103: Removed outdated scaling framework.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70103/#review213372
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70103]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 3, 2019, 12:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70103/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 12:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This old code was never updated for recent changes, is not documented,
> and currently does not work anymore. Removing it for now. Should we
> decide to bring it back in the future we should make sure it is tested
> automatically so it does not go out of sync again, and also that it is
> documented and discoverable by users.
>
>
> Diffs
> -----
>
> src/scaling/nested_exec 45ba1260e476ee20dfe013a0406f650639e9a800
> src/scaling/nested_exec.py 28ccc3f5af2d293be8d810f7082dd43388ab4435
> src/scaling/scaling_exec 3be8bc8b5bf7a1f4386db2dda82b8663d522d065
> src/scaling/scaling_exec.py e9f4a86b29485559323241587879fab946e69841
> src/scaling/scaling_sched 5c6c2476ed6a0b1275011c394f6834eef7b3a134
> src/scaling/scaling_sched.py 011e353b12465076d96378cccbc5a0ff88231844
>
>
> Diff: https://reviews.apache.org/r/70103/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70103: Removed outdated scaling framework.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70103/#review213534
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 3, 2019, 12:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70103/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 12:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This old code was never updated for recent changes, is not documented,
> and currently does not work anymore. Removing it for now. Should we
> decide to bring it back in the future we should make sure it is tested
> automatically so it does not go out of sync again, and also that it is
> documented and discoverable by users.
>
>
> Diffs
> -----
>
> src/scaling/nested_exec 45ba1260e476ee20dfe013a0406f650639e9a800
> src/scaling/nested_exec.py 28ccc3f5af2d293be8d810f7082dd43388ab4435
> src/scaling/scaling_exec 3be8bc8b5bf7a1f4386db2dda82b8663d522d065
> src/scaling/scaling_exec.py e9f4a86b29485559323241587879fab946e69841
> src/scaling/scaling_sched 5c6c2476ed6a0b1275011c394f6834eef7b3a134
> src/scaling/scaling_sched.py 011e353b12465076d96378cccbc5a0ff88231844
>
>
> Diff: https://reviews.apache.org/r/70103/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>