You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/04/19 20:25:34 UTC
[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request
#5275: Issue 5261: Support AggregationFunctions with multiple arguments
(contd).
mayankshriv commented on a change in pull request #5275: Issue 5261: Support AggregationFunctions with multiple arguments (contd).
URL: https://github.com/apache/incubator-pinot/pull/5275#discussion_r410984113
##########
File path: pinot-common/src/main/java/org/apache/pinot/parsers/utils/BrokerRequestComparisonUtils.java
##########
@@ -89,8 +89,7 @@ public static boolean validate(BrokerRequest br1, BrokerRequest br2, boolean ign
return false;
}
} else if (br2.getGroupBy() != null) {
- LOGGER.error("tGroupBy did not match, br1.getGroupBy() = null, br2.getGroupBy() = {}",
- br2.getGroupBy());
+ LOGGER.error("tGroupBy did not match, br1.getGroupBy() = null, br2.getGroupBy() = {}", br2.getGroupBy());
Review comment:
Was in the original code that's why I missed it. Will fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org