You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 04:27:40 UTC

[GitHub] [arrow] kou commented on a diff in pull request #13008: ARROW-16355: [Dev] Add "-jN" to build cpp in verify-release-candidate.sh

kou commented on code in PR #13008:
URL: https://github.com/apache/arrow/pull/13008#discussion_r859367296


##########
dev/release/verify-release-candidate.sh:
##########
@@ -616,14 +616,12 @@ test_and_install_cpp() {
     -DPARQUET_REQUIRE_ENCRYPTION=ON \
     ${ARROW_CMAKE_OPTIONS:-} \
     ${ARROW_SOURCE_DIR}/cpp
-  cmake --build . --target install
+  cmake --build . --target install -j$NPROC

Review Comment:
   `-j` doesn't exist in CMake 3.11 or earlier:  https://cmake.org/cmake/help/v3.11/manual/cmake.1.html
   
   How about defining `CMAKE_BUILD_PARALLEL_LEVEL` environment variable instead?
   
   https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html#envvar:CMAKE_BUILD_PARALLEL_LEVEL
   
   ```shell
     export CMAKE_BUILD_PARALLEL_LEVEL=${CMAKE_BUILD_PARALLEL_LEVEL:-$(nproc)}
     cmake --build ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org