[jira] [Commented] (BOOKKEEPER-1084) Make variables finale if necessary

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032617#comment-16032617 ] 

ASF GitHub Bot commented on BOOKKEEPER-1084:
--------------------------------------------

GitHub user sijie opened a pull request:

    https://github.com/apache/bookkeeper/pull/172

    BOOKKEEPER-1084: Make variables finale if necessary

    not all logger in bookkeeper & hedwig are static. some class like PendnigReadOp and LedgerEntry would have lots of objects, it might be bad. so this task is to make logger as a static variable if it didn't.
    
    with benefit, cleaning up the imports when touching that file.
    
    RB_ID=141138

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sijie/bookkeeper make_finale

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #172
    
----
commit daffc8460670cd15994bb8650add3be5a9dc2eef
Author: Sijie Guo <si...@twitter.com>
Date:   2013-04-19T00:54:55Z

    make logger as a static variable
    not all logger in bookkeeper & hedwig are static. some class like PendnigReadOp and LedgerEntry would have lots of objects, it might be bad. so this task is to make logger as a static variable if it didn't.
    
    with benefit, cleaning up the imports when touching that file.
    
    RB_ID=141138

----


> Make variables finale if necessary
> ----------------------------------
>
>                 Key: BOOKKEEPER-1084
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1084
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.5.0
>
>
> Merge commit 
> {code}
> commit daffc8460670cd15994bb8650add3be5a9dc2eef
> Author: Sijie Guo <si...@twitter.com>
> Date:   Thu Apr 18 17:54:55 2013 -0700
>     make logger as a static variable
>     not all logger in bookkeeper & hedwig are static. some class like PendnigReadOp and LedgerEntry would have lots of objects, it might be bad. so this task is to make logger as a static variable if it didn't.
>     with benefit, cleaning up the imports when touching that file.
>     RB_ID=141138
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)