You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/19 11:05:46 UTC
[GitHub] [camel] AemieJ opened a new pull request #4019: CAMEL-15302: Remove duplicate pages under eip section
AemieJ opened a new pull request #4019:
URL: https://github.com/apache/camel/pull/4019
This PR removes all the xref errors faced in PR #4015 and the build is successful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4019: CAMEL-15302: Remove duplicate pages under eip section
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4019:
URL: https://github.com/apache/camel/pull/4019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] AemieJ commented on a change in pull request #4019: CAMEL-15302: Remove duplicate pages under eip section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #4019:
URL: https://github.com/apache/camel/pull/4019#discussion_r456900404
##########
File path: core/camel-core-engine/src/main/docs/modules/eips/pages/dynamic-router.adoc
##########
@@ -1,198 +0,0 @@
-[[DynamicRouter-DynamicRouter]]
Review comment:
I have removed the whole file as `dynamic-router.adoc` as well as `dynamicRouter-eip.adoc` encompasses the same information. The same deal goes along with `request-reply.adoc` and `requestReply-eip.adoc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] AemieJ commented on pull request #4019: CAMEL-15302: Remove duplicate pages under eip section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on pull request #4019:
URL: https://github.com/apache/camel/pull/4019#issuecomment-660654146
@oscerd Within the issue, `dynamic-router.adoc` as well as `dynamicRouter-eip.adoc` encompasses the same information. The same deal goes along with `request-reply.adoc` and `requestReply-eip.adoc`. Thus within the JIRA Issue, @davsclaus mentioned to include the `-eip` files. Thus I shifted all the necessary content to the `-eip.adoc` and removed the duplicates and also edited the links for it through various docs pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #4019: CAMEL-15302: Remove duplicate pages under eip section
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4019:
URL: https://github.com/apache/camel/pull/4019#discussion_r456898561
##########
File path: core/camel-core-engine/src/main/docs/modules/eips/pages/dynamic-router.adoc
##########
@@ -1,198 +0,0 @@
-[[DynamicRouter-DynamicRouter]]
Review comment:
Why removing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org