You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/13 04:05:34 UTC

[GitHub] [skywalking] CodeDestiny opened a new issue #4505: Can skywalking exclude specified Exception？

CodeDestiny opened a new issue #4505: Can skywalking exclude specified Exception？
URL: https://github.com/apache/skywalking/issues/4505
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question
   
   ___
   ### Question
   - What do you want to know?
   In my project, develop defined BusinessException for some senerio such as parameter validate、bussiness logic validate，these exceptions are printed，but does not mean endpoint failure. 
   In skywalking，these situation are calulated for service success rate metric.Is there anyway I can config, in order to exclude the BusinessException ?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4505: Can skywalking exclude specified Exception？

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4505: Can skywalking exclude specified Exception？
URL: https://github.com/apache/skywalking/issues/4505#issuecomment-598547279
 
 
   OneAPM product did very different way. They Even can't 100% sampling, Even far from it. We are different.
   Again, this can be added If some one wants to contribute.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] CodeDestiny commented on issue #4505: Can skywalking exclude specified Exception？

Posted by GitBox <gi...@apache.org>.

CodeDestiny commented on issue #4505: Can skywalking exclude specified Exception？
URL: https://github.com/apache/skywalking/issues/4505#issuecomment-598546583
 
 
   Because in last company，we used OneAPM which can config this，but also thanks a lot

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng closed issue #4505: Can skywalking exclude specified Exception？

Posted by GitBox <gi...@apache.org>.

wu-sheng closed issue #4505: Can skywalking exclude specified Exception？
URL: https://github.com/apache/skywalking/issues/4505
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4505: Can skywalking exclude specified Exception？

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4505: Can skywalking exclude specified Exception？
URL: https://github.com/apache/skywalking/issues/4505#issuecomment-598542221
 
 
   No, we can't. Using exception to propagate error is not a good idea, and have bad performance. 
   Please consider to remove them.
   The exception is dealt with in the plugin, If you insist, you have to change plugins one by one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services