You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/07/08 18:37:11 UTC
Review Request 12327: dnsmasq propagation to vpc routervm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12327/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Bugs: CLOUDSTACK-3357
Repository: cloudstack-git
Description
-------
dnsmasq propagation to vpc routervm
Diffs
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ddfa998
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 7115499
server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/12327/diff/
Testing
-------
a bassc unit test
manual creation of vpc with a networkdomain
Thanks,
daan Hoogland
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by Chip Childers <ch...@apache.org>.
> On July 9, 2013, 6:41 p.m., Chip Childers wrote:
> > Getting this error after applying to master:
> >
> > Tests in error:
> > testConfigDnsMasq(com.cloud.network.router.VpcVirtualNetworkApplianceManagerImplTest): Failed to load ApplicationContext
FWIW, outside of the test failure this looks good to me.
- Chip
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12327/#review22926
-----------------------------------------------------------
On July 9, 2013, 6:38 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12327/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 6:38 p.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3357
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> dnsmasq propagation to vpc routervm
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ddfa998
> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 7115499
> server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12327/diff/
>
>
> Testing
> -------
>
> a bassc unit test
> manual creation of vpc with a networkdomain
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12327/#review22926
-----------------------------------------------------------
Getting this error after applying to master:
Tests in error:
testConfigDnsMasq(com.cloud.network.router.VpcVirtualNetworkApplianceManagerImplTest): Failed to load ApplicationContext
- Chip Childers
On July 9, 2013, 6:38 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12327/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 6:38 p.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3357
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> dnsmasq propagation to vpc routervm
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ddfa998
> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 7115499
> server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12327/diff/
>
>
> Testing
> -------
>
> a bassc unit test
> manual creation of vpc with a networkdomain
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12327/#review23012
-----------------------------------------------------------
Ship it!
applied to master and 4.2
- Chip Childers
On July 10, 2013, 8:14 a.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12327/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 8:14 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Jayapal Reddy, Murali Reddy, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-3357
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> dnsmasq propagation to vpc routervm
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ddfa998
> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 7115499
> server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java PRE-CREATION
> server/test/resources/VpcVirtNetAppContext.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12327/diff/
>
>
> Testing
> -------
>
> a bassc unit test
> manual creation of vpc with a networkdomain
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by Daan Hoogland <da...@gmail.com>.
I tried to apply this patch on 4.1. it won't. Does anybody have an idea on
how to implement the same in 4.1 It seems backporting is not an options as
utilities used did not exist back then.
regards,
Daan
On Wed, Jul 10, 2013 at 10:14 AM, daan Hoogland <da...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12327/
> Review request for cloudstack, Chip Childers, Jayapal Reddy, Murali
> Reddy, and Prasanna Santhanam.
> By daan Hoogland.
>
> *Updated July 10, 2013, 8:14 a.m.*
> Changes
>
> added test spring config to patch
>
> *Bugs: * CLOUDSTACK-3357
> *Repository: * cloudstack-git
> Description
>
> dnsmasq propagation to vpc routervm
>
> Testing
>
> a bassc unit test
> manual creation of vpc with a networkdomain
>
> Diffs (updated)
>
> - server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
> (ddfa998)
> - server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
> (7115499)
> - server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java
> (PRE-CREATION)
> - server/test/resources/VpcVirtNetAppContext.xml (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/12327/diff/>
>
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12327/
-----------------------------------------------------------
(Updated July 10, 2013, 8:14 a.m.)
Review request for cloudstack, Chip Childers, Jayapal Reddy, Murali Reddy, and Prasanna Santhanam.
Changes
-------
added test spring config to patch
Bugs: CLOUDSTACK-3357
Repository: cloudstack-git
Description
-------
dnsmasq propagation to vpc routervm
Diffs (updated)
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ddfa998
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 7115499
server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java PRE-CREATION
server/test/resources/VpcVirtNetAppContext.xml PRE-CREATION
Diff: https://reviews.apache.org/r/12327/diff/
Testing
-------
a bassc unit test
manual creation of vpc with a networkdomain
Thanks,
daan Hoogland
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12327/
-----------------------------------------------------------
(Updated July 9, 2013, 6:38 p.m.)
Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Prasanna Santhanam.
Bugs: CLOUDSTACK-3357
Repository: cloudstack-git
Description
-------
dnsmasq propagation to vpc routervm
Diffs
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ddfa998
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 7115499
server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/12327/diff/
Testing
-------
a bassc unit test
manual creation of vpc with a networkdomain
Thanks,
daan Hoogland
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12327/
-----------------------------------------------------------
(Updated July 9, 2013, 9:16 a.m.)
Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Prasanna Santhanam.
Changes
-------
including additional reviewers
Bugs: CLOUDSTACK-3357
Repository: cloudstack-git
Description
-------
dnsmasq propagation to vpc routervm
Diffs
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ddfa998
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 7115499
server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/12327/diff/
Testing
-------
a bassc unit test
manual creation of vpc with a networkdomain
Thanks,
daan Hoogland
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by Daan Hoogland <da...@gmail.com>.
All,
I want to backport this to 4.1.x and 4.2 as I consider it a bug.
On Tue, Jul 9, 2013 at 9:31 AM, Daan Hoogland <da...@gmail.com>wrote:
> Prasanna, Can you direct this one to some one with an insight into this
> part of the system?
>
> thanks,
> Daan
>
>
> On Mon, Jul 8, 2013 at 6:37 PM, daan Hoogland <da...@gmail.com>wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/12327/
>> Review request for cloudstack and Prasanna Santhanam.
>> By daan Hoogland.
>> *Bugs: * CLOUDSTACK-3357
>> *Repository: * cloudstack-git
>> Description
>>
>> dnsmasq propagation to vpc routervm
>>
>> Testing
>>
>> a bassc unit test
>> manual creation of vpc with a networkdomain
>>
>> Diffs
>>
>> - server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
>> (ddfa998)
>> - server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
>> (7115499)
>> - server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java
>> (PRE-CREATION)
>>
>> View Diff <https://reviews.apache.org/r/12327/diff/>
>>
>
>
Re: Review Request 12327: dnsmasq propagation to vpc routervm
Posted by Daan Hoogland <da...@gmail.com>.
Prasanna, Can you direct this one to some one with an insight into this
part of the system?
thanks,
Daan
On Mon, Jul 8, 2013 at 6:37 PM, daan Hoogland <da...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12327/
> Review request for cloudstack and Prasanna Santhanam.
> By daan Hoogland.
> *Bugs: * CLOUDSTACK-3357
> *Repository: * cloudstack-git
> Description
>
> dnsmasq propagation to vpc routervm
>
> Testing
>
> a bassc unit test
> manual creation of vpc with a networkdomain
>
> Diffs
>
> - server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
> (ddfa998)
> - server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
> (7115499)
> - server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java
> (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/12327/diff/>
>