You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2012/04/28 19:20:47 UTC
[jira] [Created] (OAK-78) waitForCommit() test failure for MK
remoting
Jukka Zitting created OAK-78:
--------------------------------
Summary: waitForCommit() test failure for MK remoting
Key: OAK-78
URL: https://issues.apache.org/jira/browse/OAK-78
Project: Jackrabbit Oak
Issue Type: Bug
Components: mk
Reporter: Jukka Zitting
Priority: Minor
The .mk.client.Client class is synchronized, which makes it fail the new waitForCommit() integration test.
There doesn't seem to be any need for synchronization in Client (the server should in any case be thread-safe), so I think we should just unsynchronize the Client method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-78) waitForCommit() test failure for MK
remoting
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264736#comment-13264736 ]
Jukka Zitting commented on OAK-78:
----------------------------------
> Wrong, the javadoc for the Client class clearly says
That's what I was referring to. There's no need for us to use just a single HttpExecutor instance and thus require synchronization of all methods. In revision 1331832 I modified the code so that a new HttpExecutor instance is created for each method call. That adds some overhead due to the extra socket connections, but avoids the concurrency bottleneck.
To avoid the connection overhead, I'd recommend using the [HttpClient|http://hc.apache.org/httpcomponents-client-ga/] library that contains a thread-safe and standards-compliant implementation of reusable connections. But that's best handled in a separate issue, assuming we want to further develop this RPC-based remoting mechanism.
> waitForCommit() test failure for MK remoting
> --------------------------------------------
>
> Key: OAK-78
> URL: https://issues.apache.org/jira/browse/OAK-78
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mk
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 0.2
>
>
> The .mk.client.Client class is synchronized, which makes it fail the new waitForCommit() integration test.
> There doesn't seem to be any need for synchronization in Client (the server should in any case be thread-safe), so I think we should just unsynchronize the Client method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-78) waitForCommit() test failure for MK
remoting
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264728#comment-13264728 ]
Dominique Pfister commented on OAK-78:
--------------------------------------
> There doesn't seem to be any need for synchronization in Client (the server
> should in any case be thread-safe), so I think we should just unsynchronize
> the Client method.
Wrong, the javadoc for the Client class clearly says:
"All public methods inside this class are completely synchronized because"
"HttpExecutor is not thread-safe."
> waitForCommit() test failure for MK remoting
> --------------------------------------------
>
> Key: OAK-78
> URL: https://issues.apache.org/jira/browse/OAK-78
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mk
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 0.2
>
>
> The .mk.client.Client class is synchronized, which makes it fail the new waitForCommit() integration test.
> There doesn't seem to be any need for synchronization in Client (the server should in any case be thread-safe), so I think we should just unsynchronize the Client method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-78) waitForCommit() test failure for MK
remoting
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved OAK-78.
------------------------------
Resolution: Fixed
Fix Version/s: 0.2
Assignee: Jukka Zitting
Fixed in revision 1331832.
> waitForCommit() test failure for MK remoting
> --------------------------------------------
>
> Key: OAK-78
> URL: https://issues.apache.org/jira/browse/OAK-78
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mk
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 0.2
>
>
> The .mk.client.Client class is synchronized, which makes it fail the new waitForCommit() integration test.
> There doesn't seem to be any need for synchronization in Client (the server should in any case be thread-safe), so I think we should just unsynchronize the Client method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-78) waitForCommit() test failure for MK
remoting
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264745#comment-13264745 ]
Dominique Pfister commented on OAK-78:
--------------------------------------
OK, but I'd expect that a change in a class's behavior will also update the associated javadoc.
Removed obsolete description in revision 1332128.
> waitForCommit() test failure for MK remoting
> --------------------------------------------
>
> Key: OAK-78
> URL: https://issues.apache.org/jira/browse/OAK-78
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mk
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 0.2
>
>
> The .mk.client.Client class is synchronized, which makes it fail the new waitForCommit() integration test.
> There doesn't seem to be any need for synchronization in Client (the server should in any case be thread-safe), so I think we should just unsynchronize the Client method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira