[GitHub] [incubator-pinot] bozhang2820 commented on issue #4398: Add more key/value pairs into LOG2M_TO_SIZE_IN_BYTES in HllSizeUtils

[GitBox <gi...@apache.org>]

bozhang2820 commented on issue #4398: Add more key/value pairs into LOG2M_TO_SIZE_IN_BYTES in HllSizeUtils
URL: https://github.com/apache/incubator-pinot/pull/4398#issuecomment-508261303
 
 
   > This is ok but what are we gaining by this change. Is the accuracy changing dramatically
   
   Yes without this change the best standard error (1.04 / sqrt(m)) is at ~4.6% when log2m = 9. With this change it goes down to ~0.57% (when log2m = 15).
   
   In fact at Uber we have a table configured with log2m = 13 and we have a similar patch to accommodate that.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org