You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Gordon King <no...@github.com.INVALID> on 2021/09/25 01:31:02 UTC

[apache/incubator-teaclave] Duplicated docker compose files (#556)

Under the `docker` folder, it contains 2 identical files as follows. Is it necessary to keep both of them ? thanks.
![image](https://user-images.githubusercontent.com/10856796/134753346-84bccc28-cb26-430c-aa3f-03225ed04af6.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/556

Re: [apache/incubator-teaclave] Duplicated docker compose files (#556)

Posted by Mingshen Sun <no...@github.com.INVALID>.
The main purpose of `doker-compose-ubuntu-1804.yml` is backward compatibility. Originally, we only provide docker for isgx driver. I think we can delete it now since we have kept them both for a while.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/556#issuecomment-927022837

Re: [apache/incubator-teaclave] Duplicated docker compose files (#556)

Posted by Mingshen Sun <no...@github.com.INVALID>.
I believe this issue was resolved in the #559 PR. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/556#issuecomment-941748288

Re: [apache/incubator-teaclave] Duplicated docker compose files (#556)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Closed #556.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/556#event-5453491412