You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/03 12:11:06 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request #3286: stm32l4: Fix small typo on stm32l4_adc.h
acassis opened a new pull request #3286:
URL: https://github.com/apache/incubator-nuttx/pull/3286
## Summary
stm32l4: Fix small typo on stm32l4_adc.h
## Impact
Only stm32l4
## Testing
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3286: stm32l4: Fix small typo on stm32l4_adc.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3286:
URL: https://github.com/apache/incubator-nuttx/pull/3286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3286: stm32l4: Fix small typo on stm32l4_adc.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3286:
URL: https://github.com/apache/incubator-nuttx/pull/3286#discussion_r606657865
##########
File path: arch/arm/src/stm32l4/hardware/stm32l4_adc.h
##########
@@ -238,7 +238,7 @@
# define ADC_CFGR_EXTSEL_T1CC1 (0x0 << ADC_CFGR_EXTSEL_SHIFT) /* 0000: Timer 1 CC1 event */
# define ADC_CFGR_EXTSEL_T1CC2 (0x01 << ADC_CFGR_EXTSEL_SHIFT) /* 0001: Timer 1 CC2 event */
# define ADC_CFGR_EXTSEL_T1CC3 (0x02 << ADC_CFGR_EXTSEL_SHIFT) /* 0010: Timer 1 CC3 event */
-# define ADC_CFGR_EXTSEL_T2CC2 (0x03 << ADC_CFGR_EXTSEL_SHIFT) /* 0011: Timer 2 CC2 event */
+# define ADC_CFGR_EXTSEL_T2CC4 (0x03 << ADC_CFGR_EXTSEL_SHIFT) /* 0011: Timer 2 CC2 event */
Review comment:
```suggestion
# define ADC_CFGR_EXTSEL_T2CC4 (0x03 << ADC_CFGR_EXTSEL_SHIFT) /* 0011: Timer 2 CC4 event */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3286: stm32l4: Fix small typo on stm32l4_adc.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3286:
URL: https://github.com/apache/incubator-nuttx/pull/3286#issuecomment-812895941
@acassis let's fix both typo in one patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org