[jira] [Commented] (YARN-3340) Mark setters to be @Public for ApplicationId/ApplicationAttemptId/ContainerId.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359188#comment-14359188 ] 

Hadoop QA commented on YARN-3340:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12704212/YARN-3340.1.patch
  against trunk revision 6dae6d1.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6944//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6944//console

This message is automatically generated.

> Mark setters to be @Public for ApplicationId/ApplicationAttemptId/ContainerId.
> ------------------------------------------------------------------------------
>
>                 Key: YARN-3340
>                 URL: https://issues.apache.org/jira/browse/YARN-3340
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Blocker
>         Attachments: YARN-3340.1.patch
>
>
> Currently, setters of ApplicaitonId/ApplicationAttemptId/ContainerId are all private, that's not correct -- user's applications need to set such ids to do query status / submit application, etc.
> We need mark such setters to be public avoiding downstream applications encounters compilation error when changes made on such setters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)