You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/18 19:12:46 UTC

[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on a change in pull request #160: add functionality of search view close using back button

PatelVatsalB21 commented on a change in pull request #160:
URL: https://github.com/apache/fineract-cn-mobile/pull/160#discussion_r597167176



##########
File path: app/src/main/java/org/apache/fineract/ui/online/DashboardActivity.java
##########
@@ -77,6 +80,10 @@ protected void onCreate(Bundle savedInstanceState) {
         }
     }
 
+    private void assignBaseFragment(FineractBaseFragment baseFragment) {
+        this.baseFragment = baseFragment;
+    }
+

Review comment:
       @EGOR-IND this looks very lengthy code. There is one solution if you want to try. Searchview assigned in every fragment is correct but instead of assigning fragment use `onPause()` in every fragment and in onPause method type `searchview.OnActionViewCollapsed()` it will make you work done with less code. For more reference follow this [pr made for similar issue](https://github.com/apache/fineract-cn-mobile/pull/149).
   
   ```suggestion
     ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org