You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (Jira)" <ji...@apache.org> on 2025/01/06 17:13:00 UTC
[jira] [Commented] (HTTPCLIENT-2354) ResponseCachingPolicy::isExplicitlyCacheable does not account for "must-revalidate"
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910314#comment-17910314 ]
Oleg Kalnichevski commented on HTTPCLIENT-2354:
-----------------------------------------------
> Per this documentation ...
[~skylar.sutton@gmail.com] Whatever this particular document states, or any other, it does not matter. What matters is what RFC 9111 [1] states. This is the only document that HttpClient 5.4.x is supposed to conform to. I will take a look whether HttpClient handles the `Cache-Control: must-revalidate, max-age=0` directive as specified by RFC 9111.
Oleg
[1] https://datatracker.ietf.org/doc/html/rfc9111
> ResponseCachingPolicy::isExplicitlyCacheable does not account for "must-revalidate"
> -----------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2354
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2354
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 5.4.1
> Reporter: Skylar Sutton
> Priority: Major
>
> Using httpclient5-cache:5.4.1, backed by an EH Cache with the following config:
> * maxCacheEntries: Integer.MAX
> * maxObjectSize: Integer.MAX
> * sharedCache: false
> * setNeverCacheHTTP10ResponsesWithQueryString: false
> * setNeverCacheHTTP11ResponsesWithQueryString: false
> Execute a call against a resource with a query string (ex: "/foo?q=bar") which returns the following CacheControl:
> {code:java}
> Cache-Control: "must-revalidate, max-age=0" {code}
> The Apache Client will fail to cache the resource, specifically because of this check in {_}ResponseCachingPolicy::isResponseCachable{_}:
> {code:java}
> if (!this.neverCache1_1ResponsesWithQueryString && !this.isExplicitlyCacheable(cacheControl, response)) {
> LOG.debug("Response is not cacheable as it is missing explicit caching headers");
> return false;
> } {code}
> More specifically, _ResponseCachingPolicy::isExplicitlyCachable_ does not contain any logic to handle the "must-revalidate" directive.
> Per this documentation, "public" is not required if "must-revalidate" is provided: [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control]
> *??"... If a request doesn't have an {{Authorization}} header, or you are already using {{s-maxage}} or {{must-revalidate}} in the response, then you don't need to use {{{}public ...{}}}"??*
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org