Size issue with commit-email.pl

[Scott Bronson <br...@rinspin.com>]

Hello.  I just added 15 700 kb files to my repository and hit commit.
My mailserver then attempted to deliver a 10 MB email to the watchers
mailing list.  Ouch.

commit-email.pl should have a configurable maximum email size, shouldn't
it?  All email above that size could be truncated.  If this sounds like
a good idea, I can create a patch for this.

Also, I noticed "Binary files differ" in the following commit
message and got a little worried that diff is being called on binary
content.  I don't see a check for the mime type in commit-email.pl.

Should I open issue tracker items for these?  Thanks,

    - Scott




Author: bronson
Date: 2004-12-23 18:44:29 -0800 (Thu, 23 Dec 2004)
New Revision: 2

Added:
   home.jpg
Log:
Add a binary file.


Added: home.jpg
===================================================================
(Binary files differ)


Property changes on: home.jpg
___________________________________________________________________
Name: svn:mime-type
   + application/octet-stream


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Size issue with commit-email.pl

[Max Bowsher <ma...@ukf.net>]

Scott Bronson wrote:
> Hello.  I just added 15 700 kb files to my repository and hit commit.
> My mailserver then attempted to deliver a 10 MB email to the watchers
> mailing list.  Ouch.
>
> commit-email.pl should have a configurable maximum email size, shouldn't
> it?  All email above that size could be truncated.  If this sounds like
> a good idea, I can create a patch for this.

Yes, I think this is needed.

> Also, I noticed "Binary files differ" in the following commit
> message and got a little worried that diff is being called on binary
> content.  I don't see a check for the mime type in commit-email.pl.

The script is letting svnlook make that decision. I don't consider that to 
be a problem.

> Should I open issue tracker items for these?  Thanks,

For the size limit, yes.
If you decide to write a patch, feel free to assign the new issue to 
yourself, and mark it as STARTED.

Don't forget to read the HACKING file, for information about submitting 
patches.

When done, send the patch to the dev@ list. If you don't get any review 
within a few days, attach the patch to the issue.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org