You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/19 16:58:26 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9167:
[log] Set detailed query info to log debug level
dpgaspar opened a new pull request #9167: [log] Set detailed query info to log debug level
URL: https://github.com/apache/incubator-superset/pull/9167
### CATEGORY
Choose one
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Send possible sensitive information to Log debug level
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9167:
[log] Set detailed query info to log debug level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9167: [log] Set detailed query info to log debug level
URL: https://github.com/apache/incubator-superset/pull/9167#issuecomment-588964837
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=h1) Report
> Merging [#9167](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e73c81b25842a16e647ec5524049b0260f090e5?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9167 +/- ##
==========================================
+ Coverage 59.08% 59.16% +0.08%
==========================================
Files 372 372
Lines 11926 11935 +9
Branches 2920 2927 +7
==========================================
+ Hits 7046 7061 +15
+ Misses 4698 4694 -4
+ Partials 182 180 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `93.54% <0%> (-6.46%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0% <0%> (ø)` | :arrow_up: |
| [superset-frontend/src/SqlLab/components/Link.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbmsuanN4) | | |
| [superset-frontend/src/SqlLab/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbmsudHN4) | `93.75% <0%> (ø)` | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `91.66% <0%> (+0.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=footer). Last update [3e73c81...8a29c7d](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #9167: [log] Set
detailed query info to log debug level
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #9167: [log] Set detailed query info to log debug level
URL: https://github.com/apache/incubator-superset/pull/9167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9167: [log] Set
detailed query info to log debug level
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9167: [log] Set detailed query info to log debug level
URL: https://github.com/apache/incubator-superset/pull/9167#issuecomment-588964837
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=h1) Report
> Merging [#9167](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e73c81b25842a16e647ec5524049b0260f090e5?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9167 +/- ##
==========================================
+ Coverage 59.08% 59.16% +0.08%
==========================================
Files 372 372
Lines 11926 11935 +9
Branches 2920 2927 +7
==========================================
+ Hits 7046 7061 +15
+ Misses 4698 4694 -4
+ Partials 182 180 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `93.54% <0%> (-6.46%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0% <0%> (ø)` | :arrow_up: |
| [superset-frontend/src/SqlLab/components/Link.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbmsuanN4) | | |
| [superset-frontend/src/SqlLab/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbmsudHN4) | `93.75% <0%> (ø)` | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9167/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `91.66% <0%> (+0.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=footer). Last update [3e73c81...327f6d1](https://codecov.io/gh/apache/incubator-superset/pull/9167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org