You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/02/18 00:09:52 UTC
Review Request 43680: GEODE-831: FreeListManager unit test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43680/
-----------------------------------------------------------
Review request for geode, Sai Boorlagadda and Swapnil Bawaskar.
Bugs: GEODE-831
https://issues.apache.org/jira/browse/GEODE-831
Repository: geode
Description
-------
Moved a bunch of stuff only used by FreeListManager from SimpleMemoryAllocatorImpl to FLM.
Removed ChunkType. It was no longer used by GemFire and complicated the code.
Removed BATCH_SIZE. It was experimental code that should not have been checked in.
added AddressableMemoryChunk interface and factory.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java dd33b156a43183a09bf8484132cbdb2e7996f042
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/AddressableMemoryChunkFactory.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java 4d1252d0e2b6a8b6501f903817b10be2fac7b3d6
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkFactory.java f7d4ba8110aade19aa9e1327647fce5f132c1e7c
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkType.java e48bb62be91b8fcbefe069aa5795ef2748ef4d64
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java ef566276e2cf86271170ded839a73d4375955151
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java 10e4148cced863aa5d9ccbf35ae1a4b87d3613c5
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunk.java 20e4a2f4bbf5026ca2b212f58017791e99aa0050
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactory.java c3f3bcc1f88cd5b874566f92df1aa05f96bbda84
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java 0a014dec4ab08d3addd97cc307f81f42cd9eff88
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlock.java 3ad9283e298a010cd0ad8de12714f55516b89cc8
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java 5c6182a63409aa9c037219e83b20d930da0c57b0
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 84e421805dbebde47b7370b898d4019f81792e07
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java 12d297b5433152f590ac45a5c1c47b08779543ff
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunk.java ed1c843d7874a8d1742638597a7499315c49c900
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java 060638708006119829785721003c973efe4fc975
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java f7d071467208954d9577a0d944e1c87a6704e282
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactoryJUnitTest.java d12b823dafd935cade7c598ad438d6eae654a05d
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkJUnitTest.java 81a59e3e7c33c326a099431510cc49351402ebdf
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java 5e54b731b761da29a10285851b9086d2c3e1649b
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java fd0eb4f778ac81b28322aacc99a0af213202cb88
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java b515959c3755f0d5f1d3102d36f34aabeee007f4
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b800977228f9579ba75cf37ee172fec1b723cbb1
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java f0f0461064426a07dc227cd778e62c04ee2e9b0d
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java daebefad18f99ae63f6124baf426a099194896fc
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternIntegrationTest.java 239cbc8817facb540ee44c0d6708b11de34f4d48
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternJUnitTest.java 21c98355f6540fefa0b54709107b38fe1dccae01
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java d9979cc8ff304c76605e7480f345ac69eb7d62b7
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SyncChunkStackJUnitTest.java aaa2ec8e919e7e35cd529c948fa01fb03236af67
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunkJUnitTest.java a98fa28d1b4e0bfd5a0c6816a5316040a8ad64de
gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteBufferByteSourceJUnitTest.java c7c7b7b563827a4b0798a6e73d79433239c59327
gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteSourceJUnitTest.java 543ef94c69d7a47f963dc03a0ffd85bd22f3d5fe
Diff: https://reviews.apache.org/r/43680/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 43680: GEODE-831: FreeListManager unit test
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43680/#review119758
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On Feb. 17, 2016, 11:09 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43680/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 11:09 p.m.)
>
>
> Review request for geode, Sai Boorlagadda and Swapnil Bawaskar.
>
>
> Bugs: GEODE-831
> https://issues.apache.org/jira/browse/GEODE-831
>
>
> Repository: geode
>
>
> Description
> -------
>
> Moved a bunch of stuff only used by FreeListManager from SimpleMemoryAllocatorImpl to FLM.
> Removed ChunkType. It was no longer used by GemFire and complicated the code.
> Removed BATCH_SIZE. It was experimental code that should not have been checked in.
> added AddressableMemoryChunk interface and factory.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java dd33b156a43183a09bf8484132cbdb2e7996f042
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/AddressableMemoryChunkFactory.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java 4d1252d0e2b6a8b6501f903817b10be2fac7b3d6
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkFactory.java f7d4ba8110aade19aa9e1327647fce5f132c1e7c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkType.java e48bb62be91b8fcbefe069aa5795ef2748ef4d64
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java ef566276e2cf86271170ded839a73d4375955151
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java 10e4148cced863aa5d9ccbf35ae1a4b87d3613c5
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunk.java 20e4a2f4bbf5026ca2b212f58017791e99aa0050
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactory.java c3f3bcc1f88cd5b874566f92df1aa05f96bbda84
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java 0a014dec4ab08d3addd97cc307f81f42cd9eff88
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlock.java 3ad9283e298a010cd0ad8de12714f55516b89cc8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java 5c6182a63409aa9c037219e83b20d930da0c57b0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 84e421805dbebde47b7370b898d4019f81792e07
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java 12d297b5433152f590ac45a5c1c47b08779543ff
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunk.java ed1c843d7874a8d1742638597a7499315c49c900
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java 060638708006119829785721003c973efe4fc975
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java f7d071467208954d9577a0d944e1c87a6704e282
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactoryJUnitTest.java d12b823dafd935cade7c598ad438d6eae654a05d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkJUnitTest.java 81a59e3e7c33c326a099431510cc49351402ebdf
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java 5e54b731b761da29a10285851b9086d2c3e1649b
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java fd0eb4f778ac81b28322aacc99a0af213202cb88
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java b515959c3755f0d5f1d3102d36f34aabeee007f4
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b800977228f9579ba75cf37ee172fec1b723cbb1
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java f0f0461064426a07dc227cd778e62c04ee2e9b0d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java daebefad18f99ae63f6124baf426a099194896fc
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternIntegrationTest.java 239cbc8817facb540ee44c0d6708b11de34f4d48
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternJUnitTest.java 21c98355f6540fefa0b54709107b38fe1dccae01
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java d9979cc8ff304c76605e7480f345ac69eb7d62b7
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SyncChunkStackJUnitTest.java aaa2ec8e919e7e35cd529c948fa01fb03236af67
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunkJUnitTest.java a98fa28d1b4e0bfd5a0c6816a5316040a8ad64de
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteBufferByteSourceJUnitTest.java c7c7b7b563827a4b0798a6e73d79433239c59327
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteSourceJUnitTest.java 543ef94c69d7a47f963dc03a0ffd85bd22f3d5fe
>
> Diff: https://reviews.apache.org/r/43680/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 43680: GEODE-831: FreeListManager unit test
Posted by Darrel Schneider <ds...@pivotal.io>.
> On Feb. 18, 2016, 1:28 p.m., Ken Howe wrote:
> > Review is still in progress, but FreeListManagerTest.java sould be FreeListManagerJUnitTest.java per project conventions.
That was the "old" convention. The new one is to just use "*Test" for tests in the unit test category; "*IntegrationTest" for tests in the integration test category; and "*DUnitTest" for tests in the distributed test category.
- Darrel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43680/#review119722
-----------------------------------------------------------
On Feb. 17, 2016, 3:09 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43680/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 3:09 p.m.)
>
>
> Review request for geode, Sai Boorlagadda and Swapnil Bawaskar.
>
>
> Bugs: GEODE-831
> https://issues.apache.org/jira/browse/GEODE-831
>
>
> Repository: geode
>
>
> Description
> -------
>
> Moved a bunch of stuff only used by FreeListManager from SimpleMemoryAllocatorImpl to FLM.
> Removed ChunkType. It was no longer used by GemFire and complicated the code.
> Removed BATCH_SIZE. It was experimental code that should not have been checked in.
> added AddressableMemoryChunk interface and factory.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java dd33b156a43183a09bf8484132cbdb2e7996f042
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/AddressableMemoryChunkFactory.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java 4d1252d0e2b6a8b6501f903817b10be2fac7b3d6
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkFactory.java f7d4ba8110aade19aa9e1327647fce5f132c1e7c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkType.java e48bb62be91b8fcbefe069aa5795ef2748ef4d64
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java ef566276e2cf86271170ded839a73d4375955151
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java 10e4148cced863aa5d9ccbf35ae1a4b87d3613c5
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunk.java 20e4a2f4bbf5026ca2b212f58017791e99aa0050
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactory.java c3f3bcc1f88cd5b874566f92df1aa05f96bbda84
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java 0a014dec4ab08d3addd97cc307f81f42cd9eff88
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlock.java 3ad9283e298a010cd0ad8de12714f55516b89cc8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java 5c6182a63409aa9c037219e83b20d930da0c57b0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 84e421805dbebde47b7370b898d4019f81792e07
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java 12d297b5433152f590ac45a5c1c47b08779543ff
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunk.java ed1c843d7874a8d1742638597a7499315c49c900
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java 060638708006119829785721003c973efe4fc975
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java f7d071467208954d9577a0d944e1c87a6704e282
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactoryJUnitTest.java d12b823dafd935cade7c598ad438d6eae654a05d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkJUnitTest.java 81a59e3e7c33c326a099431510cc49351402ebdf
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java 5e54b731b761da29a10285851b9086d2c3e1649b
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java fd0eb4f778ac81b28322aacc99a0af213202cb88
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java b515959c3755f0d5f1d3102d36f34aabeee007f4
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b800977228f9579ba75cf37ee172fec1b723cbb1
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java f0f0461064426a07dc227cd778e62c04ee2e9b0d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java daebefad18f99ae63f6124baf426a099194896fc
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternIntegrationTest.java 239cbc8817facb540ee44c0d6708b11de34f4d48
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternJUnitTest.java 21c98355f6540fefa0b54709107b38fe1dccae01
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java d9979cc8ff304c76605e7480f345ac69eb7d62b7
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SyncChunkStackJUnitTest.java aaa2ec8e919e7e35cd529c948fa01fb03236af67
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunkJUnitTest.java a98fa28d1b4e0bfd5a0c6816a5316040a8ad64de
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteBufferByteSourceJUnitTest.java c7c7b7b563827a4b0798a6e73d79433239c59327
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteSourceJUnitTest.java 543ef94c69d7a47f963dc03a0ffd85bd22f3d5fe
>
> Diff: https://reviews.apache.org/r/43680/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 43680: GEODE-831: FreeListManager unit test
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43680/#review119722
-----------------------------------------------------------
Review is still in progress, but FreeListManagerTest.java sould be FreeListManagerJUnitTest.java per project conventions.
- Ken Howe
On Feb. 17, 2016, 11:09 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43680/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 11:09 p.m.)
>
>
> Review request for geode, Sai Boorlagadda and Swapnil Bawaskar.
>
>
> Bugs: GEODE-831
> https://issues.apache.org/jira/browse/GEODE-831
>
>
> Repository: geode
>
>
> Description
> -------
>
> Moved a bunch of stuff only used by FreeListManager from SimpleMemoryAllocatorImpl to FLM.
> Removed ChunkType. It was no longer used by GemFire and complicated the code.
> Removed BATCH_SIZE. It was experimental code that should not have been checked in.
> added AddressableMemoryChunk interface and factory.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java dd33b156a43183a09bf8484132cbdb2e7996f042
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/AddressableMemoryChunkFactory.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java 4d1252d0e2b6a8b6501f903817b10be2fac7b3d6
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkFactory.java f7d4ba8110aade19aa9e1327647fce5f132c1e7c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkType.java e48bb62be91b8fcbefe069aa5795ef2748ef4d64
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java ef566276e2cf86271170ded839a73d4375955151
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java 10e4148cced863aa5d9ccbf35ae1a4b87d3613c5
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunk.java 20e4a2f4bbf5026ca2b212f58017791e99aa0050
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactory.java c3f3bcc1f88cd5b874566f92df1aa05f96bbda84
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java 0a014dec4ab08d3addd97cc307f81f42cd9eff88
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlock.java 3ad9283e298a010cd0ad8de12714f55516b89cc8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java 5c6182a63409aa9c037219e83b20d930da0c57b0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 84e421805dbebde47b7370b898d4019f81792e07
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java 12d297b5433152f590ac45a5c1c47b08779543ff
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunk.java ed1c843d7874a8d1742638597a7499315c49c900
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java 060638708006119829785721003c973efe4fc975
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java f7d071467208954d9577a0d944e1c87a6704e282
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactoryJUnitTest.java d12b823dafd935cade7c598ad438d6eae654a05d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkJUnitTest.java 81a59e3e7c33c326a099431510cc49351402ebdf
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java 5e54b731b761da29a10285851b9086d2c3e1649b
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java fd0eb4f778ac81b28322aacc99a0af213202cb88
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java b515959c3755f0d5f1d3102d36f34aabeee007f4
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b800977228f9579ba75cf37ee172fec1b723cbb1
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java f0f0461064426a07dc227cd778e62c04ee2e9b0d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java daebefad18f99ae63f6124baf426a099194896fc
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternIntegrationTest.java 239cbc8817facb540ee44c0d6708b11de34f4d48
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternJUnitTest.java 21c98355f6540fefa0b54709107b38fe1dccae01
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java d9979cc8ff304c76605e7480f345ac69eb7d62b7
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SyncChunkStackJUnitTest.java aaa2ec8e919e7e35cd529c948fa01fb03236af67
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunkJUnitTest.java a98fa28d1b4e0bfd5a0c6816a5316040a8ad64de
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteBufferByteSourceJUnitTest.java c7c7b7b563827a4b0798a6e73d79433239c59327
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteSourceJUnitTest.java 543ef94c69d7a47f963dc03a0ffd85bd22f3d5fe
>
> Diff: https://reviews.apache.org/r/43680/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 43680: GEODE-831: FreeListManager unit test
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43680/#review119757
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkFactory.java (line 29)
<https://reviews.apache.org/r/43680/#comment181103>
Now that we removed ChunkType.
Can we remove ChunkFactory & GemFireChunkFactory?
- Sai Boorlagadda
On Feb. 17, 2016, 11:09 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43680/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 11:09 p.m.)
>
>
> Review request for geode, Sai Boorlagadda and Swapnil Bawaskar.
>
>
> Bugs: GEODE-831
> https://issues.apache.org/jira/browse/GEODE-831
>
>
> Repository: geode
>
>
> Description
> -------
>
> Moved a bunch of stuff only used by FreeListManager from SimpleMemoryAllocatorImpl to FLM.
> Removed ChunkType. It was no longer used by GemFire and complicated the code.
> Removed BATCH_SIZE. It was experimental code that should not have been checked in.
> added AddressableMemoryChunk interface and factory.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java dd33b156a43183a09bf8484132cbdb2e7996f042
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/AddressableMemoryChunkFactory.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java 4d1252d0e2b6a8b6501f903817b10be2fac7b3d6
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkFactory.java f7d4ba8110aade19aa9e1327647fce5f132c1e7c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/ChunkType.java e48bb62be91b8fcbefe069aa5795ef2748ef4d64
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Fragment.java ef566276e2cf86271170ded839a73d4375955151
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java 10e4148cced863aa5d9ccbf35ae1a4b87d3613c5
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunk.java 20e4a2f4bbf5026ca2b212f58017791e99aa0050
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactory.java c3f3bcc1f88cd5b874566f92df1aa05f96bbda84
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryAllocator.java 0a014dec4ab08d3addd97cc307f81f42cd9eff88
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlock.java 3ad9283e298a010cd0ad8de12714f55516b89cc8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/MemoryBlockNode.java 5c6182a63409aa9c037219e83b20d930da0c57b0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 84e421805dbebde47b7370b898d4019f81792e07
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java 12d297b5433152f590ac45a5c1c47b08779543ff
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunk.java ed1c843d7874a8d1742638597a7499315c49c900
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java 060638708006119829785721003c973efe4fc975
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java f7d071467208954d9577a0d944e1c87a6704e282
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkFactoryJUnitTest.java d12b823dafd935cade7c598ad438d6eae654a05d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkJUnitTest.java 81a59e3e7c33c326a099431510cc49351402ebdf
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java 5e54b731b761da29a10285851b9086d2c3e1649b
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java fd0eb4f778ac81b28322aacc99a0af213202cb88
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java b515959c3755f0d5f1d3102d36f34aabeee007f4
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b800977228f9579ba75cf37ee172fec1b723cbb1
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java f0f0461064426a07dc227cd778e62c04ee2e9b0d
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java daebefad18f99ae63f6124baf426a099194896fc
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternIntegrationTest.java 239cbc8817facb540ee44c0d6708b11de34f4d48
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorFillPatternJUnitTest.java 21c98355f6540fefa0b54709107b38fe1dccae01
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java d9979cc8ff304c76605e7480f345ac69eb7d62b7
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SyncChunkStackJUnitTest.java aaa2ec8e919e7e35cd529c948fa01fb03236af67
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunkJUnitTest.java a98fa28d1b4e0bfd5a0c6816a5316040a8ad64de
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteBufferByteSourceJUnitTest.java c7c7b7b563827a4b0798a6e73d79433239c59327
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/OffHeapByteSourceJUnitTest.java 543ef94c69d7a47f963dc03a0ffd85bd22f3d5fe
>
> Diff: https://reviews.apache.org/r/43680/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>