You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Quinn Stevenson <qu...@pronoia-solutions.com> on 2016/10/04 16:30:08 UTC
Re: Any Interest in this PR?
Clebert -
It is very similar to what I contributed for Artemis.
The additions to the EmbeddedActiveMQBroker (for ActiveMQ 5.x) closely mirror what I included in the EmbeddedActiveMQResource and EmbeddedJMSResource (for Artemis).
The client resources are different - the client resources for ActiveMQ 5.x are JMS only (but they should work with an Artemis JMS Server), while the client resources for Artemis are native (i.e. not JMS specific).
I’d like to see what you put in the Artemis documentation, but I don’t know where I can find it - my Google-foo is failing me :-). Can you help me out with that?
> On Sep 30, 2016, at 5:35 AM, Clebert Suconic <cl...@gmail.com> wrote:
>
> It is the same thing you sent on Artemis. Right ?
>
> It's Merged there already. I even added a few extra things and docs. (If
> you could read the docs please)
>
> On Friday, September 30, 2016, Christopher Shannon <
> christopher.l.shannon@gmail.com <ma...@gmail.com>> wrote:
>
>> I am interested but haven't had a chance to look at it closely yet as it is
>> a big commit. But I think it would be fine to be merged into 5.15 or even
>> 5.14.2 since it is just an improvement for the junit support.
>>
>> On Thu, Sep 29, 2016 at 9:52 PM, Quinn Stevenson <
>> quinn@pronoia-solutions.com <javascript:;>> wrote:
>>
>>> I’ve had this PR open for a while now, but I haven’t heard anything back.
>>>
>>> If the community isn’t interested in this PR, please let me know so I can
>>> close it.
>>>
>>>> On Sep 16, 2016, at 3:09 PM, hqstevenson <git@git.apache.org
>> <javascript:;>> wrote:
>>>>
>>>> GitHub user hqstevenson opened a pull request:
>>>>
>>>> https://github.com/apache/activemq/pull/198
>>>>
>>>> AMQ-6428 - Add methods to EmbeddedActiveMQBroker an ActiveMQ client
>>> JUnit Rules
>>>>
>>>>
>>>>
>>>> You can merge this pull request into a Git repository by running:
>>>>
>>>> $ git pull https://github.com/hqstevenson/activemq AMQ-6428
>>>>
>>>> Alternatively you can review and apply these changes as the patch at:
>>>>
>>>> https://github.com/apache/activemq/pull/198.patch
>>>>
>>>> To close this pull request, make a commit to your master/trunk branch
>>>> with (at least) the following in the commit message:
>>>>
>>>> This closes #198
>>>>
>>>> ----
>>>> commit 343e3738b5cffdd6b95cfa257134108105f714c7
>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com <javascript:;>>
>>>> Date: 2016-09-16T20:59:13Z
>>>>
>>>> Added methods to EmbeddedActiveMQBroker to send messages, as well as
>>> JUnit Rules for ActiveMQ clients
>>>>
>>>> commit f7b5b901004b90975cb82390684e89df57eaced4
>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com <javascript:;>>
>>>> Date: 2016-09-16T20:59:47Z
>>>>
>>>> Merge branch 'master' of https://git-wip-us.apache.org/
>>> repos/asf/activemq into AMQ-6428
>>>>
>>>> commit 7be356017eecf37fa9c4884906e4eda06d8a6f19
>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com <javascript:;>>
>>>> Date: 2016-09-16T21:07:13Z
>>>>
>>>> Added license header to files
>>>>
>>>> ----
>>>>
>>>>
>>>> ---
>>>> If your project is set up for it, you can reply to this email and have
>>> your
>>>> reply appear on GitHub as well. If your project does not have this
>>> feature
>>>> enabled and wishes so, or if the feature is enabled but not working,
>>> please
>>>> contact infrastructure at infrastructure@apache.org <javascript:;> or
>> file a JIRA
>>> ticket
>>>> with INFRA.
>>>> ---
>>>
>>>
>>
>
>
> --
> Clebert Suconic
Re: Any Interest in this PR?
Posted by Clebert Suconic <cl...@gmail.com>.
The docs are part of the codebase.. I added as part of that PR I merged for you.
You can read the current version of what I I wrote here:
https://github.com/apache/activemq-artemis/blob/master/docs/user-manual/en/unit-testing.md
indexed at:
https://github.com/apache/activemq-artemis/blob/master/docs/user-manual/en/SUMMARY.md
you can build the docs yourself on master after installing gitbook:
cd docs/user-manual/en
gitbook build
or gitbook pdf
(the last will need some extra stuff installed).
or mvn -Prelease install will also build the docs for you.
On Tue, Oct 4, 2016 at 12:30 PM, Quinn Stevenson
<qu...@pronoia-solutions.com> wrote:
> Clebert -
>
> It is very similar to what I contributed for Artemis.
>
> The additions to the EmbeddedActiveMQBroker (for ActiveMQ 5.x) closely mirror what I included in the EmbeddedActiveMQResource and EmbeddedJMSResource (for Artemis).
>
> The client resources are different - the client resources for ActiveMQ 5.x are JMS only (but they should work with an Artemis JMS Server), while the client resources for Artemis are native (i.e. not JMS specific).
>
> I’d like to see what you put in the Artemis documentation, but I don’t know where I can find it - my Google-foo is failing me :-). Can you help me out with that?
>
>
>> On Sep 30, 2016, at 5:35 AM, Clebert Suconic <cl...@gmail.com> wrote:
>>
>> It is the same thing you sent on Artemis. Right ?
>>
>> It's Merged there already. I even added a few extra things and docs. (If
>> you could read the docs please)
>>
>> On Friday, September 30, 2016, Christopher Shannon <
>> christopher.l.shannon@gmail.com <ma...@gmail.com>> wrote:
>>
>>> I am interested but haven't had a chance to look at it closely yet as it is
>>> a big commit. But I think it would be fine to be merged into 5.15 or even
>>> 5.14.2 since it is just an improvement for the junit support.
>>>
>>> On Thu, Sep 29, 2016 at 9:52 PM, Quinn Stevenson <
>>> quinn@pronoia-solutions.com <javascript:;>> wrote:
>>>
>>>> I’ve had this PR open for a while now, but I haven’t heard anything back.
>>>>
>>>> If the community isn’t interested in this PR, please let me know so I can
>>>> close it.
>>>>
>>>>> On Sep 16, 2016, at 3:09 PM, hqstevenson <git@git.apache.org
>>> <javascript:;>> wrote:
>>>>>
>>>>> GitHub user hqstevenson opened a pull request:
>>>>>
>>>>> https://github.com/apache/activemq/pull/198
>>>>>
>>>>> AMQ-6428 - Add methods to EmbeddedActiveMQBroker an ActiveMQ client
>>>> JUnit Rules
>>>>>
>>>>>
>>>>>
>>>>> You can merge this pull request into a Git repository by running:
>>>>>
>>>>> $ git pull https://github.com/hqstevenson/activemq AMQ-6428
>>>>>
>>>>> Alternatively you can review and apply these changes as the patch at:
>>>>>
>>>>> https://github.com/apache/activemq/pull/198.patch
>>>>>
>>>>> To close this pull request, make a commit to your master/trunk branch
>>>>> with (at least) the following in the commit message:
>>>>>
>>>>> This closes #198
>>>>>
>>>>> ----
>>>>> commit 343e3738b5cffdd6b95cfa257134108105f714c7
>>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com <javascript:;>>
>>>>> Date: 2016-09-16T20:59:13Z
>>>>>
>>>>> Added methods to EmbeddedActiveMQBroker to send messages, as well as
>>>> JUnit Rules for ActiveMQ clients
>>>>>
>>>>> commit f7b5b901004b90975cb82390684e89df57eaced4
>>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com <javascript:;>>
>>>>> Date: 2016-09-16T20:59:47Z
>>>>>
>>>>> Merge branch 'master' of https://git-wip-us.apache.org/
>>>> repos/asf/activemq into AMQ-6428
>>>>>
>>>>> commit 7be356017eecf37fa9c4884906e4eda06d8a6f19
>>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com <javascript:;>>
>>>>> Date: 2016-09-16T21:07:13Z
>>>>>
>>>>> Added license header to files
>>>>>
>>>>> ----
>>>>>
>>>>>
>>>>> ---
>>>>> If your project is set up for it, you can reply to this email and have
>>>> your
>>>>> reply appear on GitHub as well. If your project does not have this
>>>> feature
>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>> please
>>>>> contact infrastructure at infrastructure@apache.org <javascript:;> or
>>> file a JIRA
>>>> ticket
>>>>> with INFRA.
>>>>> ---
>>>>
>>>>
>>>
>>
>>
>> --
>> Clebert Suconic
>
--
Clebert Suconic