You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/15 03:24:41 UTC
[GitHub] [flink] Myasuka opened a new pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Myasuka opened a new pull request #14656:
URL: https://github.com/apache/flink/pull/14656
## What is the purpose of the change
Since related code of checkpointing is different between Flink-1.12 and master, this PR targets for **release-1.12** branch.
Currently, no mater how many times of async checkpoint failure, job would not trigger failover. This PR ensure the mechanism of failing the job by default when async phase of checkpoint failed, which was broken in FLINK-12364.
## Brief change log
- Let `CHECKPOINT_ASYNC_EXCEPTION` could also be treated to fail the job.
- Ensure decline checkpoint with specific `CheckpointException` instead of previous `throwable`.
- If task is not running, never decline the checkpoint on task side to avoid unexpected failover again.
## Verifying this change
This change added tests and can be verified as follows:
- Added `CheckpointFailureManagerITCase#testAsyncCheckpointFailureTriggerJobFailed` to ensure job would failed once async checkpoint failed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **yes**
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-769188512
I will change the order to pick the fix of FLINK-16443 first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-767984153
@AHeise , to align with #14662, I picked your commit of FLINK-16443.
@rkhachatryan , could you also take a look at this PR targets for release-1.12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #14656:
URL: https://github.com/apache/flink/pull/14656#discussion_r566178176
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/rpc/RpcCheckpointResponder.java
##########
@@ -55,7 +56,16 @@ public void declineCheckpoint(
long checkpointId,
Throwable cause) {
+ // TODO the passed parameter 'cause' is actually always instance of CheckpointException,
+ // we should change the interfaces to narrow all declined checkpoint's throwable to
+ // CheckpointException.
Review comment:
IIUC, the same TODO was fixed in the corresponding PR for 1.13.
What's the reasoning behind not fixing it for 1.12?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cb6c9f2ed48920003bc7c51a785b154eed31ff7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760620925
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6cb6c9f2ed48920003bc7c51a785b154eed31ff7 (Fri Jan 15 03:26:23 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
}, {
"hash" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539",
"triggerID" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b76054fb0147db53c593550e4a8a1ad5449de709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
}, {
"hash" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cb6c9f2ed48920003bc7c51a785b154eed31ff7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091)
* b76054fb0147db53c593550e4a8a1ad5449de709 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
}, {
"hash" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539",
"triggerID" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cb6c9f2ed48920003bc7c51a785b154eed31ff7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091)
* b76054fb0147db53c593550e4a8a1ad5449de709 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #14656:
URL: https://github.com/apache/flink/pull/14656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
}, {
"hash" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539",
"triggerID" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"triggerType" : "PUSH"
}, {
"hash" : "a5fe3f2bc18941aac605677be1b7d7306c20caf0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a5fe3f2bc18941aac605677be1b7d7306c20caf0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b76054fb0147db53c593550e4a8a1ad5449de709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539)
* a5fe3f2bc18941aac605677be1b7d7306c20caf0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #14656:
URL: https://github.com/apache/flink/pull/14656#discussion_r566213388
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/rpc/RpcCheckpointResponder.java
##########
@@ -55,7 +56,16 @@ public void declineCheckpoint(
long checkpointId,
Throwable cause) {
+ // TODO the passed parameter 'cause' is actually always instance of CheckpointException,
+ // we should change the interfaces to narrow all declined checkpoint's throwable to
+ // CheckpointException.
Review comment:
I don't want to break the API compatibility to refactor APIs in minor version of Flink, and we could still achieve the effect to make job could fail if async checkpoint failed without refactoring APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cb6c9f2ed48920003bc7c51a785b154eed31ff7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cb6c9f2ed48920003bc7c51a785b154eed31ff7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
}, {
"hash" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539",
"triggerID" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"triggerType" : "PUSH"
}, {
"hash" : "a5fe3f2bc18941aac605677be1b7d7306c20caf0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12615",
"triggerID" : "a5fe3f2bc18941aac605677be1b7d7306c20caf0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5fe3f2bc18941aac605677be1b7d7306c20caf0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12615)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14656:
URL: https://github.com/apache/flink/pull/14656#issuecomment-760627740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12091",
"triggerID" : "6cb6c9f2ed48920003bc7c51a785b154eed31ff7",
"triggerType" : "PUSH"
}, {
"hash" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539",
"triggerID" : "b76054fb0147db53c593550e4a8a1ad5449de709",
"triggerType" : "PUSH"
}, {
"hash" : "a5fe3f2bc18941aac605677be1b7d7306c20caf0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12615",
"triggerID" : "a5fe3f2bc18941aac605677be1b7d7306c20caf0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b76054fb0147db53c593550e4a8a1ad5449de709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12539)
* a5fe3f2bc18941aac605677be1b7d7306c20caf0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12615)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org