[GitHub] [incubator-datasketches-java] jmalkin commented on issue #267: use ThreadLocalRandom instead of Random

[GitBox <gi...@apache.org>]

jmalkin commented on issue #267: use ThreadLocalRandom instead of Random
URL: https://github.com/apache/incubator-datasketches-java/pull/267#issuecomment-524072546
 
 
   Huh, I guess we need to figure out how to disable the old Yahoo CLAbot.
   
   The main drawback of ThreadLocalRandom is that you can't set a random seed. That's something of a mixed bag in a multithreaded environment, of course -- you don't want to have the a shared seed between threads!
   
   And note that the data structure itself isn't thread-safe. The assumption is that you'll have independent reservoir sample sand would merge them later.
   
   Anyway, thank you. We'll discuss this on the project's dev@ list, but I have no inherent objection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org